Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions django/db/migrations/serializer.py
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,17 @@ def serialize(self):
)


class GenericAliasSerializer(BaseSerializer):
def serialize(self):
imports = set()
# Avoid iterating self.value, because it returns itself.
# https://github.com/python/cpython/issues/103450
for item in self.value.__args__:
_, item_imports = serializer_factory(item).serialize()
imports.update(item_imports)
return repr(self.value), imports


class IterableSerializer(BaseSerializer):
def serialize(self):
imports = set()
Expand Down Expand Up @@ -364,6 +375,7 @@ class Serializer:
decimal.Decimal: DecimalSerializer,
(functools.partial, functools.partialmethod): FunctoolsPartialSerializer,
FUNCTION_TYPES: FunctionTypeSerializer,
types.GenericAlias: GenericAliasSerializer,
collections.abc.Iterable: IterableSerializer,
(COMPILED_REGEX_TYPE, RegexObject): RegexSerializer,
uuid.UUID: UUIDSerializer,
Expand Down
6 changes: 6 additions & 0 deletions tests/migrations/test_writer.py
Original file line number Diff line number Diff line change
Expand Up @@ -1237,6 +1237,12 @@ def test_serialize_non_identifier_keyword_args(self):
self.assertEqual(result.args, instance.args)
self.assertEqual(result.kwargs, instance.kwargs)

def test_serialize_generic_alias(self):
self.assertSerializedEqual(dict[str, float])

def test_serialize_generic_alias_complex_args(self):
self.assertSerializedEqual(dict[str, models.Manager])

def test_register_serializer(self):
class ComplexSerializer(BaseSerializer):
def serialize(self):
Expand Down