[pull] main from VirusTotal:main#122
Merged
Merged
Conversation
We needed to determine the proper size of the import entries by leveraging `imports_format`, which was not leveraged previously. This size and offset of the entry can be determined via https://github.com/llvm/llvm-project/blob/main/llvm/include/llvm/BinaryFormat/MachO.h#L1083-L1087. ```rust let entry_size = match header.imports_format { 2 => 8, // DYLD_CHAINED_IMPORT_ADDEND (u64) 3 => 16, // DYLD_CHAINED_IMPORT_ADDEND64 (u128) _ => 4, // Default u32 }; ``` Fixes #541
When some module is used in a rule without the corresponding `import` statement, the error message now contains a fix proposal that adds the statement at the beginning of the file.
In the language server, the quick fix that inserts the `import` statement when a module is used without being imported, was being applied at the wrong place in the source code because the span used for creating the fix was incorrect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )