Skip to content

Timer: Fix dispose return type#2136

Merged
Methuselah96 merged 1 commit intothree-types:masterfrom
eunjiyun:fix-timer-dispose-return
May 9, 2026
Merged

Timer: Fix dispose return type#2136
Methuselah96 merged 1 commit intothree-types:masterfrom
eunjiyun:fix-timer-dispose-return

Conversation

@eunjiyun
Copy link
Copy Markdown
Contributor

@eunjiyun eunjiyun commented May 6, 2026

Summary

  • Aligns Timer.dispose() with the JavaScript implementation.
  • Keeps the change limited to the declaration file.

Evidence

  • JS implementation: src/core/Timer.js:140
  • Declaration: types/three/src/core/Timer.d.ts:66
  • Mismatch: the declaration exposed a chainable return value that the implementation does not return.

Check

  • Not run: dependencies were not installed locally.
  • Checked the declaration diff manually.

Copy link
Copy Markdown
Contributor

@Methuselah96 Methuselah96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Methuselah96
Copy link
Copy Markdown
Contributor

CI is not working for some reason, probably unrelated to this PR. Will merge once that is fixed.

@Methuselah96 Methuselah96 merged commit adb6af2 into three-types:master May 9, 2026
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants