Skip to content

fix: correct UniformGroup.dispose declaration#2137

Merged
Methuselah96 merged 1 commit intothree-types:masterfrom
eunjiyun:fix-uniformsgroup-dispose-return
May 9, 2026
Merged

fix: correct UniformGroup.dispose declaration#2137
Methuselah96 merged 1 commit intothree-types:masterfrom
eunjiyun:fix-uniformsgroup-dispose-return

Conversation

@eunjiyun
Copy link
Copy Markdown
Contributor

@eunjiyun eunjiyun commented May 7, 2026

Summary

  • Aligns UniformsGroup.dispose() with the JavaScript implementation.
  • Keeps the change limited to the declaration file.

Evidence

  • JS implementation: three.js/src/core/UniformsGroup.js:130
  • Declaration: types/three/src/core/UniformsGroup.d.ts:34
  • Mismatch: the declaration exposed a chainable return value that the implementation does not return.

Check

  • Confirmed dispose() returns undefined at runtime.
  • pnpm test failed due to an unrelated ESLint plugin error.

@Methuselah96 Methuselah96 merged commit 56f3f2a into three-types:master May 9, 2026
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants