fix(bridge): cap BatchResult FailedCount and increase test timeouts

BatchCalls reads ALL events from the block, not per-extrinsic. In
multi-validator setups where multiple force_batch extrinsics land in
the same block, Utility.ItemFailed events from other validators'
batches inflate the FailedCount, producing negative SuccessCount.

Cap FailedCount at len(calls) to prevent misleading negative counts.
The on-chain behavior was already correct — this is a reporting fix.

Also increase T9/MV9 timeout from 600s to 900s and T7/MV7 from 60s
to 300s. With batched execution, 50 burns require ~3 expiry cycles
(~22 burns per cycle × ~3 min per cycle) to fully complete.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: sameh-farouk

clients/tfchain-client-go/batch.go

@@ -49,7 +49,16 @@ func (s *Substrate) BatchCalls(identity Identity, calls []types.Call) (*BatchRes
 		// ItemFailed events are emitted by force_batch for each failed call.
 		// The event payload does not carry the batch-call index — only a DispatchError.
 		// We count failures but cannot reliably map them to specific call positions.
+		//
+		// IMPORTANT: getEventRecords reads ALL events from the block, not just
+		// those emitted by this extrinsic. In multi-validator setups, multiple
+		// validators may submit force_batch extrinsics in the same block. Each
+		// validator sees ItemFailed events from ALL batches, inflating the count.
+		// Cap failedCount at len(calls) to prevent negative SuccessCount.
 		failedCount := len(resp.Events.Utility_ItemFailed)
+		if failedCount > len(calls) {
+			failedCount = len(calls)
+		}
 		if failedCount > 0 {
 			result.FailedCount = failedCount
 			result.SuccessCount = len(calls) - failedCount

scripts/bridge_mv_tests.js

@@ -549,8 +549,8 @@ async function testMV9_expiredBatchRecovery () {
     // handleWithdrawReady submits them sequentially — each using its stored sequence
     // number, so all succeed in one pass.
     //
-    // After all Stellar payments complete, each handleWithdrawReady calls
-    // SetWithdrawExecuted individually (could be batched in a future optimization).
+    // After all Stellar payments in a cycle complete, BatchSetWithdrawExecuted
+    // confirms all in one force_batch. Multiple expiry cycles may be needed.
     for (let i = 1; i <= 3; i++) startValidator(i)
     log('All 3 validators restarted. Recovering expired burns via batch re-proposal...')
     log(`Expected: 1 force_batch re-proposes all ${N}, then all ${N} Stellar payments execute in sequence`)
@@ -567,7 +567,7 @@ async function testMV9_expiredBatchRecovery () {
         lastReported = count
       }
       if (bal >= beforeStellar + expectedNet - 1e-7) return bal
-    }, { timeoutMs: 600_000, intervalMs: 10_000, desc: `all ${N} burns delivered (+${expectedNet} TFT)` })
+    }, { timeoutMs: 900_000, intervalMs: 10_000, desc: `all ${N} burns delivered (+${expectedNet} TFT)` })
 
     const delta = Math.round((finalStellar - beforeStellar) * TFT_DECIMALS) / TFT_DECIMALS
     log(`All ${N} burns delivered: +${delta} TFT (expected +${expectedNet})`)
@@ -597,7 +597,7 @@ async function testMV7_cleanState () {
       const refunds = await api.query.tftBridgeModule.refundTransactions.entries()
       const mints = await api.query.tftBridgeModule.mintTransactions.entries()
       return burns.length === 0 && refunds.length === 0 && mints.length === 0
-    }, { timeoutMs: 60_000, intervalMs: 5000, desc: 'all active tx maps to drain' })
+    }, { timeoutMs: 300_000, intervalMs: 5000, desc: 'all active tx maps to drain' })
     pass(name, counter)
   } catch (e) {
     // On timeout, report what's left

scripts/bridge_tests.js

@@ -551,7 +551,7 @@ async function test9_expiredBatchRecovery () {
         lastReported = count
       }
       if (bal >= beforeStellar + expectedNet - 1e-7) return bal
-    }, { timeoutMs: 600_000, intervalMs: 10_000, desc: `all ${N} burns delivered (+${expectedNet} TFT)` })
+    }, { timeoutMs: 900_000, intervalMs: 10_000, desc: `all ${N} burns delivered (+${expectedNet} TFT)` })
 
     const delta = Math.round((finalStellar - beforeStellar) * TFT_DECIMALS) / TFT_DECIMALS
     log(`All ${N} burns delivered: +${delta} TFT (expected +${expectedNet})`)
@@ -581,7 +581,7 @@ async function test7_cleanState () {
       const refunds = await api.query.tftBridgeModule.refundTransactions.entries()
       const mints = await api.query.tftBridgeModule.mintTransactions.entries()
       return burns.length === 0 && refunds.length === 0 && mints.length === 0
-    }, { timeoutMs: 60_000, intervalMs: 5000, desc: 'all active tx maps to drain' })
+    }, { timeoutMs: 300_000, intervalMs: 5000, desc: 'all active tx maps to drain' })
     pass(name, counter)
   } catch (e) {
     // On timeout, report what's left