fix(bridge): harden tests, fix Go bugs A/B/C/F/H, clean up pallet and docs

Test improvements:
- Extract sendStellarPayment to shared bridge_helpers.js (DRY)
- Add MV6a below-minimum withdraw test (parity with SV test6)
- Increase MV5 batch size from 3 to 5 (match SV test2)
- Fix markTestPhase early-return bug with finally blocks
- Remove dead waitForValReady function
- Add bridge_instrumentation.js for event collection and analysis

Go bridge fixes (stellar.go):
- Issue A: fix && to || in deposit asset filter (creditedEffect check)
- Issue B: add per-payment asset validation with warning log for non-TFT
- Issue C: fix || to && in StatBridgeAccount balance filter
- Issue F: fix return nil,nil to continue in op loop (highest severity)
- Issue H: reuse HTTP client in StellarWallet instead of creating per-call

Pallet cleanup:
- Collapse redundant ensure!/get into single .ok_or() read in
  set_stellar_burn_transaction_executed

Docs:
- Fix deposit fee "10 TFT" to "1 TFT" in bridging, multinode, single_node

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: sameh-farouk

bridge/docs/bridging.md

@@ -11,7 +11,7 @@ This document will explain how you can transfer TFT from TF Chain to Stellar and
 
 ## Stellar to TF Chain
 
-Transfer the TFT from your Stellar wallet to bridge wallet address that you configured. A depositfee will be taken (10 TFT on mainnet/testnet by default), so make sure you send a larger amount than the fee.
+Transfer the TFT from your Stellar wallet to bridge wallet address that you configured. A depositfee will be taken (1 TFT on mainnet/testnet by default), so make sure you send a larger amount than the fee.
 
 ### Transfer to TF Chain
 
@@ -29,7 +29,7 @@ To deposit to a TF Grid object, this object **must** exists. If the object is no
 ## TF Chain to Stellar
 
 Browse to https://polkadot.js.org/apps/?rpc=wss%3A%2F%2Ftfchain.grid.tf#/extrinsics (for mainnet), select tftBridgeModule and extrinsic: `swap_to_stellar()`. Provide your stellar target address and amount and sign it with your account holding the tft balance.
-Again, a withdrawfee will be taken (10 TFT on mainnet/testnet by default), so make sure you send a larger amount than the fee.
+Again, a withdrawfee will be taken (1 TFT on mainnet/testnet by default), so make sure you send a larger amount than the fee.
 
 The amount withdrawn from TF Chain will be sent to your Stellar wallet.
 

bridge/docs/multinode.md

@@ -177,4 +177,4 @@ Now construct a memo message indicating which twin you will deposit to: "twin_TW
 ./stellar-utils transfer 50 "twin_1" GAYJSBPBQ3J32CZZ72OM3GZP646KSVD3V5QB3WBJSSGPYHYS5MZSS4Z6 --secret SDGRCA63GSP4MSASFAWX5FORTS6ATQMK63YL6ZMF7YIFEJVBTLJDJA3M
 ```
 
-Now you should have received the tokens minus the depositfee on your account on tfchain (the default depositfee is 10 TFT).
+Now you should have received the tokens minus the depositfee on your account on tfchain (the default depositfee is 1 TFT).

bridge/docs/single_node.md

@@ -107,4 +107,4 @@ Now construct a memo message indicating which twin you will deposit to: "twin_TW
 ./stellar-utils transfer GAYJSBPBQ3J32CZZ72OM3GZP646KSVD3V5QB3WBJSSGPYHYS5MZSS4Z6 50 "twin_1" --secret SDGRCA63GSP4MSASFAWX5FORTS6ATQMK63YL6ZMF7YIFEJVBTLJDJA3M
 ```
 
-Now you should have received the tokens minus the depositfee on your account on tfchain (the default depositfee is 10 TFT).
+Now you should have received the tokens minus the depositfee on your account on tfchain (the default depositfee is 1 TFT).

bridge/tfchain_bridge/pkg/stellar/stellar.go

@@ -49,6 +49,7 @@ type StellarWallet struct {
 	// differ in test/dev environments that use a custom issuer.
 	resolvedAssetCode   string
 	resolvedAssetIssuer string
+	httpClient          *http.Client
 }
 
 type TraceIdKey struct{}
@@ -65,6 +66,24 @@ func NewStellarWallet(ctx context.Context, config *pkg.StellarConfig) (*StellarW
 		config:  config,
 	}
 
+	retryClient := retryablehttp.NewClient()
+	retryClient.RetryMax = 3
+	retryClient.RetryWaitMin = 2 * time.Second
+	retryClient.RetryWaitMax = 5 * time.Second
+	retryClient.CheckRetry = func(ctx context.Context, resp *http.Response, err error) (bool, error) {
+		if ctx.Err() != nil {
+			return false, ctx.Err()
+		}
+		if err != nil {
+			return true, nil
+		}
+		if resp.StatusCode == 429 || (resp.StatusCode >= 500 && resp.StatusCode <= 599) {
+			return true, nil
+		}
+		return false, nil
+	}
+	w.httpClient = retryClient.StandardClient()
+
 	account, err := w.getAccountDetails(config.StellarBridgeAccount)
 	if err != nil {
 		return nil, err
@@ -642,7 +661,7 @@ func (w *StellarWallet) processTransaction(tx hProtocol.Transaction) ([]MintEven
 		}
 
 		creditedEffect := effect.(horizoneffects.AccountCredited)
-		if creditedEffect.Code != asset[0] && creditedEffect.Issuer != asset[1] {
+		if creditedEffect.Code != asset[0] || creditedEffect.Issuer != asset[1] {
 			continue
 		}
 
@@ -654,14 +673,28 @@ func (w *StellarWallet) processTransaction(tx hProtocol.Transaction) ([]MintEven
 		senders := make(map[string]*big.Int)
 		for _, op := range ops.Embedded.Records {
 			if op.GetType() != "payment" {
-				return nil, nil
+				continue
 			}
 
 			PaymentOperation := op.(operations.Payment)
 			if PaymentOperation.To != w.config.StellarBridgeAccount || PaymentOperation.From == w.config.StellarBridgeAccount {
 				continue
 			}
 
+			// Reject non-TFT payments — log as suspicious
+			if PaymentOperation.Code != asset[0] || PaymentOperation.Issuer != asset[1] {
+				logger.Warn().
+					Str("event_action", "non_tft_payment_rejected").
+					Str("event_kind", "alert").
+					Str("from", PaymentOperation.From).
+					Str("asset_code", PaymentOperation.Code).
+					Str("asset_issuer", PaymentOperation.Issuer).
+					Str("amount", PaymentOperation.Amount).
+					Str("tx_hash", PaymentOperation.TransactionHash).
+					Msg("non-TFT payment to bridge detected — skipping")
+				continue
+			}
+
 			parsedAmount, err := amount.ParseInt64(PaymentOperation.Amount)
 			if err != nil {
 				continue
@@ -749,30 +782,7 @@ func (w *StellarWallet) getHorizonClient() (*horizonclient.Client, error) {
 	if w.config.StellarHorizonUrl != "" {
 		client = &horizonclient.Client{HorizonURL: w.config.StellarHorizonUrl}
 	}
-
-	// custom HTTP client with retry logic
-	retryClient := retryablehttp.NewClient()
-	retryClient.RetryMax = 3
-	retryClient.RetryWaitMin = 2 * time.Second
-	retryClient.RetryWaitMax = 5 * time.Second
-
-	retryClient.CheckRetry = func(ctx context.Context, resp *http.Response, err error) (bool, error) {
-		if ctx.Err() != nil {
-			return false, ctx.Err()
-		}
-
-		if err != nil {
-			return true, nil
-		}
-
-		if resp.StatusCode == 429 || (resp.StatusCode >= 500 && resp.StatusCode <= 599) {
-			return true, nil
-		}
-
-		return false, nil
-	}
-
-	client.HTTP = retryClient.StandardClient()
+	client.HTTP = w.httpClient
 
 	return client, nil
 }
@@ -817,7 +827,7 @@ func (w *StellarWallet) StatBridgeAccount() (string, error) {
 	asset := w.getAssetCodeAndIssuer()
 
 	for _, balance := range acc.Balances {
-		if balance.Code == asset[0] || balance.Issuer == asset[1] {
+		if balance.Code == asset[0] && balance.Issuer == asset[1] {
 			return balance.Balance, nil
 		}
 	}

scripts/bridge_helpers.js

@@ -10,6 +10,7 @@
 
 const fs = require('fs')
 const https = require('https')
+const StellarSdk = require('@stellar/stellar-sdk')
 
 // ─── Logging & test result helpers ──────────────────────────────────────────
 
@@ -92,6 +93,38 @@ async function waitForAccount (address, server, retries = 12) {
   throw new Error(`Account ${address} not found after ${retries} attempts`)
 }
 
+/**
+ * Send a Stellar payment (TFT asset) with optional memo.
+ * @param {object} horizon - Horizon.Server instance
+ * @param {string} issuerAddress - TFT issuer public key
+ * @param {string} networkPassphrase - Stellar network passphrase
+ * @param {string} fromSecret - Sender's Stellar secret key
+ * @param {string} toAddress - Destination Stellar public key
+ * @param {string|number} amount - Amount to send (string for Stellar precision)
+ * @param {string|null} [memo=null] - Optional text memo (e.g. "twin_<id>")
+ * @returns {Promise<object>} Horizon submit result (includes .hash)
+ */
+async function sendStellarPayment (horizon, issuerAddress, networkPassphrase, fromSecret, toAddress, amount, memo = null) {
+  const kp = StellarSdk.Keypair.fromSecret(fromSecret)
+  const TFTAsset = new StellarSdk.Asset('TFT', issuerAddress)
+  const acc = await horizon.loadAccount(kp.publicKey())
+
+  const builder = new StellarSdk.TransactionBuilder(acc, {
+    fee: '1000',
+    networkPassphrase
+  }).addOperation(StellarSdk.Operation.payment({
+    destination: toAddress,
+    asset: TFTAsset,
+    amount: String(amount)
+  })).setTimeout(30)
+
+  if (memo) builder.addMemo(StellarSdk.Memo.text(String(memo)))
+
+  const tx = builder.build()
+  tx.sign(kp)
+  return horizon.submitTransaction(tx)
+}
+
 // ─── Polling helper ─────────────────────────────────────────────────────────
 
 /**
@@ -169,6 +202,7 @@ module.exports = {
   friendbot,
   waitForAccount,
   waitUntil,
+  sendStellarPayment,
   swapToStellar,
   TFT,
   TFT_DECIMALS