fix(bridge): reset expiry timer on re-proposal after burn/refund expiry#1081
Merged
Conversation
…expiry After on_finalize expires a burn or refund transaction, re-proposals add signatures via add_stellar_sig_burn_transaction / add_stellar_sig_refund_transaction but tx.block was never updated. This caused on_finalize to immediately re-expire the transaction in the same block the new signature was added (since current_block - old_block >= RetryInterval was still true). Also removes dead code in propose_stellar_burn_transaction_or_add_sig where a redundant contains_key check made the block-update branch unreachable. Closes #1080 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Cover the scenario the existing suite missed: a first signature added when current_block - tx.block has again reached RetryInterval must reset tx.block so on_finalize (which runs after extrinsics in the same block) does not wipe the signature immediately. Both tests fail without the fix (tx.block is not reset) and pass with it: - burn_signature_after_expiry_resets_block_and_survives - refund_signature_after_expiry_resets_block_and_survives Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…flow (#1091) The repository rename (tfchain -> ledger_chain) changed the runner checkout path to /__w/ledger_chain/ledger_chain, but the safe.directory exception was hardcoded to /__w/tfchain/tfchain, so git still rejected the repo with "detected dubious ownership" (exit 128) at the Git config step. Use $GITHUB_WORKSPACE so the exception always matches the real checkout path, regardless of repository name. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tx.blockto current block when the first signature is added after an expiry, preventing immediate re-expiry byon_finalizepropose_stellar_burn_transaction_or_add_sigwhere a redundantcontains_keycheck made the block-update branch unreachableCloses #1080