fix(bridge): correct error wrapping, trace_id key, and a log message

[sameh-farouk]

Summary

Three small diagnostics/observability fixes in the bridge, decomposed out of the larger #1079 work. No change to fund flow or control flow — purely what gets logged/reported. Bridge-only, no runtime upgrade.

Changes

1. Wrong error variable wrapped in Bridge.Start (bridge.go:149,193)

Both subscription arms check data.Err != nil but wrap the stale outer-scope err:

case data := <-tfchainSub:
    if data.Err != nil {
        return errors.Wrap(err, "failed to get tfchain events") // wraps stale `err`, not data.Err
    }

A real subscription failure was therefore reported with the wrong (often nil/empty) cause, masking the actual error on the bridge's exit path. Fixed to wrap data.Err in both arms.

2. trace_id always logged as <nil> (stellar.go:371)

The stellar_transaction_submitted success log read the trace id with the string key ctx.Value("trace_id"), but the value is stored under the typed key TraceIdKey{} (set in CreatePaymentWithSignaturesAndSubmit/CreateRefundPaymentWithSignaturesAndSubmit). So every submitted-tx log line emitted trace_id=<nil>. Note the sibling underfunded-alert log at stellar.go:356 already uses TraceIdKey{} correctly — this aligns the success log with it.

3. Copy-paste log message (client.go:66)

RetrySetWithdrawExecuted calls SetBurnTransactionExecuted but logged "error while setting refund transaction as executed". Corrected to "burn transaction".

Logic reasoning & regression-vector verification

• dockerize node and add it to graphql setup #1: Both branches are entered only when data.Err != nil, so data.Err is guaranteed non-nil where it's now wrapped — strictly more correct, no nil-wrap risk. Control flow unchanged (still returns).
• document architecture and reason #2: The ctx reaching submitTransaction is ctx_with_trace_id (carries TraceIdKey{}), so the value resolves correctly now. Pure logging value; no control-flow effect.
• investigate test release #3: String-literal change only.

Testing

• go build ./... — OK
• go vet ./... — OK
• gofmt -l — clean

🤖 Generated with Claude Code