Skip to content

perf(bridge): fetch transaction operations once in processTransaction #1098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sameh-farouk merged 1 commit into from
Jun 1, 2026
Merged

perf(bridge): fetch transaction operations once in processTransaction #1098

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions bridge/tfchain_bridge/pkg/stellar/stellar.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -502,6 +502,13 @@ func (w *StellarWallet) processTransaction(tx hProtocol.Transaction) ([]MintEven
asset := w.getAssetCodeAndIssuer()

var mintEvents []MintEvent
// A transaction's operations are identical no matter how many times the bridge
// account is credited within it, so fetch them at most once and reuse the result
// across all matching account_credited effects. Previously this Horizon call was
// made once per matching effect, refetching the same data when a single
// transaction credited the bridge more than once (#1051).
var ops operations.OperationsPage
opsFetched := false
for _, effect := range effects.Embedded.Records {
if effect.GetAccount() != w.config.StellarBridgeAccount {
continue
Expand All @@ -520,9 +527,12 @@ func (w *StellarWallet) processTransaction(tx hProtocol.Transaction) ([]MintEven
continue
}

ops, err := w.getOperationEffect(tx.Hash)
if err != nil {
continue
if !opsFetched {
ops, err = w.getOperationEffect(tx.Hash)
if err != nil {
continue
}
opsFetched = true
}

senders := make(map[string]*big.Int)
Expand Down
Loading