Skip to content

Support multiple substrate URLs#1028

Open
sameh-farouk wants to merge 2 commits intodevelopmentfrom
development-support-multiple-substrate-urls
Open

Support multiple substrate URLs#1028
sameh-farouk wants to merge 2 commits intodevelopmentfrom
development-support-multiple-substrate-urls

Conversation

@sameh-farouk
Copy link
Copy Markdown
Member

Description

Add support for configure the bridge with multiple substrate URLs for redundancy

Related Issues:

#1027

Checklist:

Please delete options that are not relevant.

  • My change requires a change to the documentation and I have updated it accordingly
  • My commits follow this conventional commits guide.

@sameh-farouk sameh-farouk requested a review from LeeSmet as a code owner January 22, 2025 11:14
@AhmedHanafy725
Copy link
Copy Markdown

The naming is confusing; the variable is still called url, but it's an array. I suggest updating it to urls

Rename TfchainURL to TfchainURLs, Tfchain_url to Tfchain_urls, and
url parameter to urls throughout the bridge code and docs to reflect
that the field is now a string slice, not a single string.

Addresses review feedback on #1028.
@codacy-production
Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 29 complexity · 0 duplication

Metric Results
Complexity 29
Duplication 0

View in Codacy

TIP This summary will be updated as you push new changes. Give us feedback

@sameh-farouk
Copy link
Copy Markdown
Member Author

The naming is confusing; the variable is still called url, but it's an array. I suggest updating it to urls

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants