chore(activation-service): upgrade pino, jsonschema, http-errors#1085
Open
sameh-farouk wants to merge 1 commit intodevelopmentfrom
Open
chore(activation-service): upgrade pino, jsonschema, http-errors#1085sameh-farouk wants to merge 1 commit intodevelopmentfrom
sameh-farouk wants to merge 1 commit intodevelopmentfrom
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
TIP This summary will be updated as you push new changes. Give us feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consolidates Snyk PRs #1032, #1033, #1034 into one clean PR (they conflicted after #1031 was merged).
Testing
Tested locally with all upgrades applied:
GET /activation/→ 200 (serves React SPA)POST /activation/activate→ 400 with validation errors (jsonschema working)GET /nonexistent→ 404 (http-errors working)Closes #1032, closes #1033, closes #1034