Don't break until all pages are paginated, update lock file#177
Merged
zaelgohary merged 1 commit intodevelopmentfrom Dec 11, 2025
Merged
Don't break until all pages are paginated, update lock file#177zaelgohary merged 1 commit intodevelopmentfrom
zaelgohary merged 1 commit intodevelopmentfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
AhmedHanafy725
approved these changes
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue happened because the Stellar Horizon API doesn't filter by asset code server-side. The SDK requests all payments for the account and filters client-side by assetCodeFilter: 'TFT'. Fixed by continuing the loop until all pages are paginated.
threefoldtech/threefold_connect#1151