Skip to content

Don't break until all pages are paginated, update lock file#177

Merged
zaelgohary merged 1 commit intodevelopmentfrom
development_fix_list_txs
Dec 11, 2025
Merged

Don't break until all pages are paginated, update lock file#177
zaelgohary merged 1 commit intodevelopmentfrom
development_fix_list_txs

Conversation

@zaelgohary
Copy link
Copy Markdown
Collaborator

The issue happened because the Stellar Horizon API doesn't filter by asset code server-side. The SDK requests all payments for the account and filters client-side by assetCodeFilter: 'TFT'. Fixed by continuing the loop until all pages are paginated.

threefoldtech/threefold_connect#1151

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.36%. Comparing base (278f1b6) to head (6c6b3d4).

Additional details and impacted files
@@               Coverage Diff               @@
##           development     #177      +/-   ##
===============================================
- Coverage        63.36%   62.36%   -1.00%     
===============================================
  Files               26       26              
  Lines             1201     1201              
===============================================
- Hits               761      749      -12     
- Misses             440      452      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zaelgohary zaelgohary merged commit 49fe7a7 into development Dec 11, 2025
2 checks passed
@zaelgohary zaelgohary deleted the development_fix_list_txs branch December 11, 2025 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants