Fix eslint warnings and update eslint (#4183)

* ESLINT: fix vue/singleline-html-element-content-newline

* ESLINT: fix vue/attributes-order

* ESLINT: fix vue/html-self-closing

* fix: vue/attribute-hyphenation

* ESLINT: ignore multi-word-component for old components

* eslint: vue/no-template-shadow

* eslint: update rules

* eslint: apply vue/multiline-html-element-content-newline

* eslint fix no-unused-vars

* eslint fix no-unused-vars

* eslint fix no-unused-vars

* eslint fix vue/component-definition-name-casing

* eslint fix vue/html-closing-bracket-newline

* eslint: apply simple sort import

* apply eslint fix

* apply eslint fix unused var

* apply eslint fix

* chore: reorganize eslint rules into off/warn/error categories and update severity levels

* eslint ignore prefer-spread

* fix: correct casing in SelectedNode property references to selectedNode

* chore: clean up eslint rules and add ngx global declaration

* refactor: rename props to slotProps in template activator slots and reorder v-model attribute

* merge development

Author: 0oM4R

eslint.config.js

@@ -9,13 +9,29 @@ import { defineConfigWithVueTs, vueTsConfigs } from "@vue/eslint-config-typescri
 // This returns an ARRAY of config objects optimized for Vue+TS
 const vueTsGeneratedConfigs = defineConfigWithVueTs(pluginVue.configs["flat/recommended"], vueTsConfigs.recommended, {
   rules: {
-    "@typescript-eslint/no-explicit-any": "warn",
-    "vue/multi-word-component-names": "warn",
+    // --- OFF rules ---
+    // TODO: enable this rule after https://github.com/threefoldtech/tfgrid-sdk-ts/issues/4075
+    "@typescript-eslint/no-explicit-any": "off",
     "vue/no-v-text-v-html-on-component": "off",
-    "@typescript-eslint/no-unused-expressions": "warn",
-    "@typescript-eslint/no-unused-vars": `warn`,
+    "vue/max-attributes-per-line": "off",
+    "vue/no-v-html": "off",
+    "vue/singleline-html-element-content-newline": "off",
+    "vue/html-self-closing": "off",
+    "vue/html-indent": "off",
+    "vue/require-explicit-emits": "off",
+    "vue/require-default-prop": "off",
+    "@typescript-eslint/no-unused-expressions": "off",
+    
+    // --- WARN rules ---
     "@typescript-eslint/no-duplicate-enum-values": "warn",
-    "vue/no-dupe-keys": "warn",
+    
+    // --- ERROR rules ---
+    "vue/multi-word-component-names": "error",
+    "@typescript-eslint/no-unused-vars": "error",
+    "vue/no-template-shadow": "error",
+    "vue/multiline-html-element-content-newline": "error",
+    "vue/component-definition-name-casing": "error",
+    "vue/no-dupe-keys": "error",
   },
 });
 
@@ -62,23 +78,24 @@ export default [
     },
     rules: {
       ...tseslint.configs.eslintRecommended.rules,
-      "@typescript-eslint/no-unused-vars": "warn",
 
+      // --- OFF rules ---
       "no-console": "off",
-      "prettier/prettier": "warn",
-      "simple-import-sort/imports": "warn",
-
       "@typescript-eslint/no-var-requires": "off",
+      // TODO: enable this rule after https://github.com/threefoldtech/tfgrid-sdk-ts/issues/4075
       "@typescript-eslint/no-explicit-any": "off",
       "@typescript-eslint/no-empty-function": "off",
       "@typescript-eslint/ban-ts-comment": "off",
       "@typescript-eslint/no-non-null-assertion": "off",
+      "@typescript-eslint/no-empty-object-type": "off",
+
+      // --- WARN rules ---
+      "prettier/prettier": "warn",
       "prefer-spread": "warn",
       "@typescript-eslint/no-restricted-types": [
         "warn",
         {
           types: {
-            "{}": "Use `unknown` instead.",
             "Function": "Use specific function types instead.",
             "Object": "Use `Record<string, unknown>` or specific object types instead.",
             "String": "Use `string` instead.",
@@ -87,9 +104,12 @@ export default [
           },
         },
       ],
-      "@typescript-eslint/no-empty-object-type": "warn",
       "@typescript-eslint/no-unsafe-function-type": "warn",
       "@typescript-eslint/no-wrapper-object-types": "warn",
+
+      // --- ERROR rules ---
+      "@typescript-eslint/no-unused-vars": "error",
+      "simple-import-sort/imports": "error",
     },
   },
   ...vueConfig,

packages/graphql_client/src/clients/abstract_client.ts

@@ -102,10 +102,13 @@ export abstract class AbstractClient {
 
   private static normalizeFields<T>(fields: PartialBoolean<T>): string {
     return Object.entries(fields)
-      .reduce((out, [key, value]: any) => {
-        out.push(value === true ? key : `${key}{${AbstractClient.normalizeFields(value)}}`);
-        return out;
-      }, <string[]>[])
+      .reduce(
+        (out, [key, value]: any) => {
+          out.push(value === true ? key : `${key}{${AbstractClient.normalizeFields(value)}}`);
+          return out;
+        },
+        <string[]>[],
+      )
       .join(",");
   }
 }

packages/graphql_client/src/clients/client.ts

@@ -40,6 +40,7 @@ export class TFGridGqlClient extends AbstractClient {
   public merge<T extends MergableQuery>(queries: T) {
     const options: RequestOptions[] = [];
     for (const query in queries) {
+      // eslint-disable-next-line prefer-spread
       options.push(this[`__${query}` as any].apply(this, queries[query]));
     }
 
@@ -68,14 +69,14 @@ type NormalizeMerge<T> = {
       ? Q[]
       : unknown
     : K extends keyof ByIdQueries
-    ? ReturnType<ByIdQueries[K]> extends Promise<infer Q>
-      ? Q
-      : unknown
-    : K extends keyof ConnectionQueries
-    ? ReturnType<ConnectionQueries[K]> extends Promise<infer Q>
-      ? Q
-      : unknown
-    : unknown;
+      ? ReturnType<ByIdQueries[K]> extends Promise<infer Q>
+        ? Q
+        : unknown
+      : K extends keyof ConnectionQueries
+        ? ReturnType<ConnectionQueries[K]> extends Promise<infer Q>
+          ? Q
+          : unknown
+        : unknown;
 };
 
 export interface TFGridGqlClient extends ListQueries, ByIdQueries, ConnectionQueries {}

packages/graphql_client/src/clients/list_queries.ts

@@ -3,7 +3,6 @@ import {
   Account,
   ArrayWhere,
   BaseWhere,
-  BigInt,
   BoolWhere,
   BurnTransaction,
   City,

packages/graphql_client/src/types/index.ts

@@ -12,8 +12,8 @@ export type PartialBoolean<T> = {
       ? PartialBoolean<Q>
       : true
     : T[K] extends object
-    ? PartialBoolean<T[K]>
-    : true;
+      ? PartialBoolean<T[K]>
+      : true;
 };
 
 type __BaseWhere<T> = { eq: T; not_eq: T; gt: T; gte: T; lt: T; lte: T; in: T[]; not_in: T[]; }; // prettier-ignore

packages/graphql_client/src/utils/index.ts

@@ -1,8 +1,5 @@
 import { ValidationError } from "@threefold/types";
 type AssertReturn = void | never;
-function panic(message: string): never {
-  throw new Error(message);
-}
 
 /**
  * @description

packages/grid_client/scripts/applications/algorand.ts

@@ -17,6 +17,7 @@ async function getDeployment(client, vms) {
   log("================= Getting deployment information =================");
 }
 
+// eslint-disable-next-line @typescript-eslint/no-unused-vars
 async function cancel(client, vms) {
   const resultVM = await client.machines.delete(vms);
   log("================= Canceling the deployment =================");

packages/grid_client/scripts/applications/casperlabs.ts

@@ -34,6 +34,7 @@ async function getDeployment(client, vms, gw) {
   log("================= Getting deployment information =================");
 }
 
+// eslint-disable-next-line @typescript-eslint/no-unused-vars
 async function cancel(client, vms, gw) {
   const resultVM = await client.machines.delete(vms);
   const resultGateway = await client.gateway.delete_name(gw);

packages/grid_client/scripts/applications/discourse.ts

@@ -37,6 +37,7 @@ async function getDeployment(client, vms, gw) {
   log("================= Getting deployment information =================");
 }
 
+// eslint-disable-next-line @typescript-eslint/no-unused-vars
 async function cancel(client, vms, gw) {
   const resultVM = await client.machines.delete(vms);
   const resultGateway = await client.gateway.delete_name(gw);

packages/grid_client/scripts/applications/funkwhale.ts

@@ -34,6 +34,7 @@ async function getDeployment(client, vms, gw) {
   log("================= Getting deployment information =================");
 }
 
+// eslint-disable-next-line @typescript-eslint/no-unused-vars
 async function cancel(client, vms, gw) {
   const resultVM = await client.machines.delete(vms);
   const resultGateway = await client.gateway.delete_name(gw);