Skip to content

Commit 7fab922

Browse files
authored
Remove deep from profile & public IP watchers, refactor weblet layout watcher (#4454)
1 parent aae3d82 commit 7fab922

3 files changed

Lines changed: 14 additions & 22 deletions

File tree

packages/playground/src/components/weblet_layout.vue

Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -353,18 +353,15 @@ const onlyIPV4TftPrice = ref<number>();
353353
const onlyIPV4UsdPrice = ref<number>();
354354
355355
watch(
356-
() => [props.cpu, props.memory, props.disk, props.ipv4, props.dedicated, props.selectedNode],
357-
debounce((value, oldValue) => {
358-
if (
359-
oldValue &&
360-
value[0] === oldValue[0] &&
361-
value[1] === oldValue[1] &&
362-
value[2] === oldValue[2] &&
363-
value[3] === oldValue[3] &&
364-
value[4] === oldValue[4] &&
365-
value[5] === oldValue[5]
366-
)
367-
return;
356+
[
357+
() => props.cpu,
358+
() => props.memory,
359+
() => props.disk,
360+
() => props.ipv4,
361+
() => props.dedicated,
362+
() => props.selectedNode,
363+
],
364+
debounce(() => {
368365
shouldUpdateCost.value = true;
369366
}, 500),
370367
{ immediate: true },

packages/playground/src/dashboard/components/public_ips_table.vue

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
show-select
1919
return-object
2020
@update:options="
21-
(options: any ) => {
21+
(options: any) => {
2222
page = options.page;
2323
pageSize = options.itemsPerPage;
2424
getFarmPublicIp(true, { page, size: pageSize });
@@ -27,9 +27,7 @@
2727
>
2828
<template #top>
2929
<v-alert>
30-
<h4 class="text-center font-weight-medium">
31-
Public IPs
32-
</h4>
30+
<h4 class="text-center font-weight-medium">Public IPs</h4>
3331
</v-alert>
3432
</template>
3533
<template #[`item.ip`]="{ item }">
@@ -70,9 +68,7 @@
7068
<v-divider />
7169
</v-card-text>
7270
<v-card-actions class="justify-end mb-1 mr-2">
73-
<v-btn color="anchor" @click="showDialogue = false">
74-
Close
75-
</v-btn>
71+
<v-btn color="anchor" @click="showDialogue = false"> Close </v-btn>
7672
<v-btn
7773
text="Delete"
7874
:loading="isRemoving"
@@ -186,7 +182,7 @@ export default {
186182
farmId: props.farmId,
187183
}));
188184
const modelItems = items.value.map(item => plainToInstance(RemoveFarmIPModel, item));
189-
await gridStore.grid.farms.removeFarmIps({ips:modelItems});
185+
await gridStore.grid.farms.removeFarmIps({ ips: modelItems });
190186
setTimeout(async () => {
191187
await getFarmPublicIp(true, { page: page.value, size: pageSize.value });
192188
createCustomToast("IP is deleted successfully!", ToastType.success);
@@ -209,7 +205,6 @@ export default {
209205
await getFarmPublicIp(true, { page: page.value, size: pageSize.value });
210206
}, 20000);
211207
},
212-
{ deep: true },
213208
);
214209
return {
215210
gridStore,

packages/playground/src/weblets/profile_manager.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -261,7 +261,7 @@ watch(
261261
balance.value = undefined;
262262
}
263263
},
264-
{ immediate: true, deep: true },
264+
{ immediate: true },
265265
);
266266
267267
function logout() {

0 commit comments

Comments
 (0)