Fix eslint warnings and update eslint

[0oM4R]

Description

Most of the changes are done automatically using eslint --fix

Changes

update eslint rules, ignore some waringins that wont be fixed, and fix other warinngs

Related Issues

#4086

Tested Scenarios

TO BE UPDATED

• grid client tests :https://github.com/threefoldtech/tfgrid-sdk-ts/actions/runs/15304662570
• https://github.com/threefoldtech/tfgrid-sdk-ts/actions/runs/15322711670/job/43109824692

Documentation PR

For UI changes, Please provide the Documentation PR on info_grid

To consider

Preliminary Checks:

• Preliminary Checks
  • Does it completely address the issue linked?
  • What about edge cases?
  • Does it meet the specified acceptance criteria?
  • Are there any unintended side effects?
  • Does the PR adhere to the team's coding conventions, style guides, and best practices?
  • Does it integrate well with existing features?
  • Does it impact the overall performance of the application?
  • Are there any bottlenecks or slowdowns?
  • Has it been optimized for efficiency?
  • Has it been adequately tested with unit, integration, and end-to-end tests?
  • Are there any known defects or issues?
  • Is the code well-documented?
  • Are changes to documentation reflected in the code?

UI Checks:

• UI Checks
  • If a UI design is provided/ does it follow it?
  • Does every button work?
  • Is the data displayed logical? Is it what you expected?
  • Does every validation work?
  • Does this interface feel intuitive?
  • What about slow network? Offline?
  • What if the gridproxy/graphql/chain is failing?
  • What would a first time user have a hard time navigating here?

Code Quality Checks:

• Code Quality Checks
  • Code formatted/linted? Are there unused imports? .. etc
  • Is there redundant/repeated code?
  • Are there conditionals that are always true or always false?
  • Can we write this more concisely?
  • Can we reuse this code? If yes, where?
  • Will the changes be easy to maintain and update in the future?
  • Can this code become too complex to understand for other devs?
  • Can this code cause future integration problems?

Testing Checklist

• Does it Meet the specified acceptance criteria.
• Test if changes can affect any other functionality.
• Tested with unit, integration, and end-to-end tests.
• Tested the un-happy path and rollback scenarios.
• Documentation updated to meet the latest changes.
• Check automated tests working successfully with the changes.
• Can be covered by automated tests.

General Checklist

• Tests included
• Build pass
• Documentation
• Code format and docstring
• Screenshots/Video attached (needed for UI changes)

[amiraabouhadid]

please update test scenarios

[0oM4R]

please update test scenarios

will do, please continue review

[samaradel]

When I ran yarn lint or yarn check-eslint, I got:

[0oM4R]

When I ran yarn lint or yarn check-eslint, I got:

@samaradel Is there something wrong? looks like it passed successfully

[amiraabouhadid]

please resolve merge conflicts

[amiraabouhadid]

works

please consider the given warning

[0oM4R]

works please consider the given warning

as I said in the scurm this is not an ESLint warning, this warning is related to the performance and not considered as eslint warning

[amiraabouhadid]

#4205

needs more testing

[amiraabouhadid]

contract deletion works, deployments work, listing deployment work, deleting delpoyment work , adding domain works, renting/unrenting nodes works, ssh key selection works
I see grid client tests are passing

[samaradel]

please fix the conflicts

[0oM4R]

STATS NJS WORKS