Cache service URLs#4466
Merged
Merged
Conversation
zaelgohary
requested review from
0oM4R,
AhmedHanafy725,
Mahmoud-Emad,
MohamedElmdary and
amiraabouhadid
as code owners
Contributor
AhmedHanafy725
left a comment
AhmedHanafy725
left a comment
There was a problem hiding this comment.
Please invalidate this cache also if the connect method failed
| }; | ||
|
|
||
| const SERVICE_URLS_CACHE_KEY = "service_urls_cache"; | ||
| const SERVICE_URLS_CACHE_TTL = 5 * 60 * 1000; // 5 minutes |
Contributor
There was a problem hiding this comment.
Can we increase that to one hour?
AhmedHanafy725
approved these changes
Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#4450