Implement signing feature by AlaaElattar · Pull Request #1003 · threefoldtech/grid_connect

AlaaElattar · 2025-04-27T13:38:22Z

Changes

Added signing screens.
User can hash data with md5 and sign it with one of its wallets.
Data can be given through text, qr code or a link.

2025-04-27.16.37.20.mp4

Related Issues

Sign url content using one of the wallet by scanning QRcode #559

Tested Scenarios

A list of scenarios tried to match the deliverables

Tested all screens with valid and invalid data inputs.

AhmedHanafy725

Please add a destination URL in all of the signing methods to send the signature to that destination in a post request with an application/json header, and set the signed data in the signature key
{ "signature": "<signed data>" }

AhmedHanafy725 · 2025-04-28T09:25:45Z

+        setState(() {
+          linkError = 'Missing required parameters';
+        });
+        _showInvalidLinkDialog();


tried to use the raw content of the repo readme as the link but it fails
https://raw.githubusercontent.com/threefoldtech/tfgrid-sdk-dart/refs/heads/development/README.md

Co-authored-by: AhmedHanafy725 <41957921+AhmedHanafy725@users.noreply.github.com>

AhmedHanafy725 · 2025-04-30T07:11:37Z

@ehab-hassan, can you have a look at the design here?

ehab-hassan · 2025-04-30T08:45:31Z

@ehab-hassan, can you have a look at the design here?

All good to me, just small comments
Keep all buttons sizes in the App to be the same font as the sign-in

old

New

For signing in, use this.
https://pictogrammers.com/library/mdi/icon/draw/

AlaaElattar · 2025-04-30T12:37:16Z

@ehab-hassan, can you have a look at the design here?

All good to me, just small comments Keep all buttons sizes in the App to be the same font as the sign-in

old

New

For signing in, use this. https://pictogrammers.com/library/mdi/icon/draw/

Updated the icon.

AhmedHanafy725 · 2025-05-04T09:11:55Z

+
+  @override
+  Widget build(BuildContext context) {
+    final wallets = ref.watch(walletsNotifier);


What if the wallets were not loaded?

2025-05-05.13.55.03.mp4

Implement signing feature

6f33f32

AhmedHanafy725 requested changes Apr 28, 2025

View reviewed changes

AlaaElattar marked this pull request as draft April 28, 2025 10:24

AlaaElattar and others added 9 commits April 28, 2025 13:52

Update app/lib/jrouter.dart

834c1aa

Co-authored-by: AhmedHanafy725 <41957921+AhmedHanafy725@users.noreply.github.com>

Update app/lib/apps/sign/sign.dart

ca9d2e5

Co-authored-by: AhmedHanafy725 <41957921+AhmedHanafy725@users.noreply.github.com>

Update app/lib/screens/signing/signing.dart

a34ad10

Co-authored-by: AhmedHanafy725 <41957921+AhmedHanafy725@users.noreply.github.com>

Update app/lib/screens/signing/signing.dart

a6a4f2f

Co-authored-by: AhmedHanafy725 <41957921+AhmedHanafy725@users.noreply.github.com>

Update app/lib/screens/signing/signing.dart

3321a1f

Co-authored-by: AhmedHanafy725 <41957921+AhmedHanafy725@users.noreply.github.com>

Update app/lib/screens/signing/sign_with_text.dart

31c3108

Co-authored-by: AhmedHanafy725 <41957921+AhmedHanafy725@users.noreply.github.com>

Update app/lib/screens/signing/sign_with_text.dart

d24a33e

Co-authored-by: AhmedHanafy725 <41957921+AhmedHanafy725@users.noreply.github.com>

add (hex encoded) faded && update qrcode logic

0d6bb9b

update sign_with_url to try to fetch content first

7e1ce45

AlaaElattar marked this pull request as ready for review April 28, 2025 11:59

add optional field for destination url

04e3388

add signing in registered screen

e47a6c6

AhmedHanafy725 requested changes Apr 30, 2025

View reviewed changes

AlaaElattar marked this pull request as draft April 30, 2025 08:11

AlaaElattar added 2 commits April 30, 2025 12:07

apply pr comments

6c2c403

create base class for signing screens

7210631

update signing icon && remove unused import

095237d

AlaaElattar marked this pull request as ready for review April 30, 2025 12:38

AlaaElattar requested a review from AhmedHanafy725 April 30, 2025 12:38

move sendSignedData to signing_service file

56ff04f

AhmedHanafy725 reviewed May 4, 2025

View reviewed changes

AlaaElattar marked this pull request as draft May 5, 2025 08:56

handle not loading wallets

ce561c3

AlaaElattar marked this pull request as ready for review May 5, 2025 10:54

AlaaElattar added 4 commits May 5, 2025 16:06

move all wallets logic to signing mixin

2e3b194

Update styling of snackbars

705ff41

increase size of spinning && remove background color from error

6eb34d8

update CircularProgressIndicator to be consistent with app

bdfd1a6

AhmedHanafy725 approved these changes May 6, 2025

View reviewed changes

AlaaElattar merged commit 789cb07 into development May 6, 2025
2 checks passed

AlaaElattar deleted the development_signing branch May 6, 2025 11:23

AlaaElattar mentioned this pull request May 13, 2025

Change buttons styling #1018

Open

Conversation

AlaaElattar commented Apr 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Related Issues

Tested Scenarios

Uh oh!

AhmedHanafy725 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AhmedHanafy725 Apr 28, 2025

Choose a reason for hiding this comment

Uh oh!

AlaaElattar Apr 28, 2025

Choose a reason for hiding this comment

Uh oh!

AhmedHanafy725 commented Apr 30, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ehab-hassan commented Apr 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AlaaElattar commented Apr 30, 2025

Uh oh!

AhmedHanafy725 May 4, 2025

Choose a reason for hiding this comment

Uh oh!

AlaaElattar May 5, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

AlaaElattar commented Apr 27, 2025 •

edited

Loading

ehab-hassan commented Apr 30, 2025 •

edited

Loading