Activate Stellar in imported wallets#1011
Merged
Merged
Conversation
Contributor
Author
2025-05-06.14.02.57.mp4 |
zaelgohary
reviewed
May 6, 2025
zaelgohary
reviewed
May 6, 2025
zaelgohary
reviewed
May 6, 2025
Comment on lines
+83
to
+84
| if (double.parse(_selectedWallet!.stellarBalance) < (tftPrice * 3)) { | ||
| setState(() { |
Contributor
There was a problem hiding this comment.
Can we use a constant instead of hardcoding the value 3, just to make things clearer?
Contributor
Author
There was a problem hiding this comment.
- This 3 is the required xlms for activation.
zaelgohary
reviewed
May 7, 2025
Contributor
AhmedHanafy725
requested changes
May 7, 2025
Contributor
AhmedHanafy725
left a comment
There was a problem hiding this comment.
What if the wallet is already activated but doesn't have the trustline?
Contributor
|
Maybe also it would be good if we show the wallet balance in the dropdown beside its name, so the user can select based on the balance |
Contributor
Author
Contributor
|
When the wallet is activated, it's shown as |
Contributor
AhmedHanafy725
left a comment
There was a problem hiding this comment.
In some cases, just handle the balance if it's == -1 and don't handle the new value -2, please check them.
Co-authored-by: AhmedHanafy725 <41957921+AhmedHanafy725@users.noreply.github.com>
Co-authored-by: AhmedHanafy725 <41957921+AhmedHanafy725@users.noreply.github.com>
Co-authored-by: AhmedHanafy725 <41957921+AhmedHanafy725@users.noreply.github.com>
Co-authored-by: AhmedHanafy725 <41957921+AhmedHanafy725@users.noreply.github.com>
Co-authored-by: AhmedHanafy725 <41957921+AhmedHanafy725@users.noreply.github.com>
AhmedHanafy725
approved these changes
May 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





Changes
Related Issues
Tested Scenarios