Skip to content

remove inconsistent fields from market stats #1082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlaaElattar merged 2 commits into from
Jun 2, 2025
Merged

remove inconsistent fields from market stats #1082

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f07fc9b
remove inconsistent fields from market stats
AlaaElattar Jun 2, 2025
dae2790
remove unused fields
AlaaElattar Jun 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions app/lib/models/market_data.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,14 @@
class TftMarketData {
final double lastPrice;
final double lastUsdPrice;
final double change24h;
final double high24h;
final double low24h;
final double volume24h;

TftMarketData({
required this.lastPrice,
required this.lastUsdPrice,
required this.change24h,
required this.high24h,
required this.low24h,
required this.volume24h,
});

factory TftMarketData.fromTrades(List<dynamic> trades) {
Expand All @@ -25,41 +21,28 @@ class TftMarketData {

double high24h = lastUsdcPrice;
double low24h = lastUsdcPrice;
double volume24h = 0;

final oldestTrade = trades.last;
final double oldestUsdcPrice = double.parse(oldestTrade['base_amount']) /
double.parse(oldestTrade['counter_amount']);

for (var trade in trades) {
double usdcPrice = double.parse(trade['base_amount']) /
double.parse(trade['counter_amount']);
high24h = usdcPrice > high24h ? usdcPrice : high24h;
low24h = usdcPrice < low24h ? usdcPrice : low24h;
volume24h += double.parse(trade['counter_amount']);
}

final double change24h =
((lastUsdcPrice - oldestUsdcPrice) / oldestUsdcPrice) * 100;

return TftMarketData(
lastPrice: 1 / lastPrice,
lastUsdPrice: lastUsdcPrice,
change24h: change24h,
high24h: high24h,
low24h: low24h,
volume24h: volume24h / 1000,
);
}

factory TftMarketData.empty() {
return TftMarketData(
lastPrice: 0,
lastUsdPrice: 0,
change24h: 0,
high24h: 0,
low24h: 0,
volume24h: 0,
);
}
}
4 changes: 0 additions & 4 deletions app/lib/screens/market/overview.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,8 +440,6 @@ class _OverviewWidgetState extends ConsumerState<OverviewWidget> {
'${marketData!.lastPrice.toStringAsFixed(7)} USDC'),
_buildMarketColumn('Last USD Price',
'\$${marketData!.lastUsdPrice.toStringAsFixed(7)}'),
_buildMarketColumn('24H Change',
'${marketData!.change24h.toStringAsFixed(7)}%'),
],
),
),
Expand All @@ -455,8 +453,6 @@ class _OverviewWidgetState extends ConsumerState<OverviewWidget> {
'${marketData!.high24h.toStringAsFixed(7)} USDC'),
_buildMarketColumn('24H Low',
'${marketData!.low24h.toStringAsFixed(7)} USDC'),
_buildMarketColumn('24H Volume',
'${marketData!.volume24h.toStringAsFixed(7)}K USDC'),
],
),
),
Expand Down