Skip to content

Fix timer memory leaks in login and authentication screens #1189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zaelgohary wants to merge 1 commit into
base: development
Choose a base branch
from
Open

Fix timer memory leaks in login and authentication screens #1189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions app/lib/screens/authentication_screen.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,14 @@ class AuthenticationScreenState extends State<AuthenticationScreen> {
WidgetsBinding.instance.addPostFrameCallback((_) => checkFingerprint());
}

@override
void dispose() {
if (widget.loginData != null && widget.loginData!.isMobile == false) {
timer.cancel();
}
super.dispose();
}

timeoutTimer() async {
if (!mounted) {
timer.cancel();
Expand Down
8 changes: 8 additions & 0 deletions app/lib/screens/login_screen.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,14 @@ class _LoginScreenState extends State<LoginScreen> with BlockAndRunMixin {
});
}

@override
void dispose() {
if (!isMobileCheck) {
timer.cancel();
}
super.dispose();
}

timeoutTimer() async {
if (!mounted) {
timer.cancel();
Expand Down