Skip to content

Ensure farming is mounted before setting state #1198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zaelgohary wants to merge 1 commit into
base: development
Choose a base branch
from
Open

Ensure farming is mounted before setting state #1198

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 17 additions & 14 deletions app/lib/screens/farm_screen.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ class _FarmScreenState extends ConsumerState<FarmScreen>
}

void _setLoadingState() {
if (!mounted) return;
setState(() {
loading = true;
failed = false;
Expand All @@ -103,6 +104,7 @@ class _FarmScreenState extends ConsumerState<FarmScreen>
}

void _handleSuccess() {
if (!mounted) return;
setState(() {
loading = false;
failed = false;
Expand All @@ -111,20 +113,20 @@ class _FarmScreenState extends ConsumerState<FarmScreen>
}

void _handleFailure(String userMessage, {Object? error}) {
if (mounted) {
final errorSnackbar = SnackBar(
content: Text(
userMessage,
style: Theme.of(context)
.textTheme
.bodyMedium!
.copyWith(color: Theme.of(context).colorScheme.errorContainer),
),
duration: const Duration(seconds: 3),
);
ScaffoldMessenger.of(context).clearSnackBars();
ScaffoldMessenger.of(context).showSnackBar(errorSnackbar);
}
if (!mounted) return;

final errorSnackbar = SnackBar(
content: Text(
userMessage,
style: Theme.of(context)
.textTheme
.bodyMedium!
.copyWith(color: Theme.of(context).colorScheme.errorContainer),
),
duration: const Duration(seconds: 3),
);
ScaffoldMessenger.of(context).clearSnackBars();
ScaffoldMessenger.of(context).showSnackBar(errorSnackbar);

setState(() {
loading = false;
Expand Down Expand Up @@ -366,6 +368,7 @@ class _FarmScreenState extends ConsumerState<FarmScreen>
}

_addFarm(Farm farm) {
if (!mounted) return;
setState(() {
_tabController.index == 0 ? v3Farms.add(farm) : v4Farms.add(farm);
});
Expand Down