Skip to content

Update getTradingHistory function#155

Merged
AlaaElattar merged 1 commit into
developmentfrom
development_trading_history
May 12, 2025
Merged

Update getTradingHistory function#155
AlaaElattar merged 1 commit into
developmentfrom
development_trading_history

Conversation

@AlaaElattar
Copy link
Copy Markdown
Contributor

Description

  • Fix issue of history not bring retrieved right.

Changes

  • Included base && counter assets when retrieving trades.

Related Issues

List of related issues

Checklist

  • Tests included
  • Build pass
  • Code format
  • Screenshots/Video attached (needed for UI changes)

@AlaaElattar AlaaElattar merged commit d3bd965 into development May 12, 2025
2 checks passed
@AlaaElattar AlaaElattar deleted the development_trading_history branch May 12, 2025 10:00
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.80%. Comparing base (4ef4d3b) to head (ce29ee5).
Report is 1 commits behind head on development.

Additional details and impacted files
@@             Coverage Diff              @@
##           development     #155   +/-   ##
============================================
  Coverage        63.80%   63.80%           
============================================
  Files               26       26           
  Lines             1177     1177           
============================================
  Hits               751      751           
  Misses             426      426           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants