Skip to content

Filter domain selector to only show valid access nodes #4460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zaelgohary wants to merge 2 commits into
base: development
Choose a base branch
from
Open

Filter domain selector to only show valid access nodes #4460

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
542fa95
Filter access nodes, edit gateway filter options
zaelgohary Nov 25, 2025
f414ca0
Merge branch 'development' into development_fix_access_node_filter
zaelgohary Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions packages/playground/src/components/node_selector/TfDomainName.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@
<script lang="ts">
import { type FarmInfo, Features, type FilterOptions, type NodeInfo } from "@threefold/grid_client";
import noop from "lodash/fp/noop.js";
import { default as PrivateIp } from "private-ip";
import { computed, getCurrentInstance, nextTick, onMounted, onUnmounted, type PropType, ref, watch } from "vue";

import { type InputValidatorService, useInputRef } from "@/hooks/input_validator";
Expand Down Expand Up @@ -150,7 +151,10 @@ export default {
onAfterTask({ data }) {
const currentPage = pagination.value.page;
if (!loadedPages.value.has(currentPage)) {
loadedDomains.value = loadedDomains.value.concat(data as NodeInfo[]);
const validNodes = (data as NodeInfo[]).filter(
node => node.publicConfig?.ipv4 && PrivateIp(node.publicConfig.ipv4.split("/")[0]) === false,
);
loadedDomains.value = loadedDomains.value.concat(validNodes);
loadedPages.value.add(currentPage);
}
pagination.value.next();
Expand All @@ -169,7 +173,8 @@ export default {
const enableCustomDomain = ref(false);
const size = ref(window.env.PAGE_SIZE);
const filters = computed<FilterOptions>(() => ({
gateway: true,
accessNodeV4: true,
accessNodeV6: true,
size: size.value,
page: Math.max(1, pagination.value.page),
farmId: enableCustomDomain.value ? props.farm?.farmId : undefined,
Expand Down