Support multiple hub urls from zos config#23
Merged
Conversation
Signed-off-by: nabil salah <nabil.salah203@gmail.com>
Nabil-Salah
requested review from
Eslam-Nawara,
Omarabdul3ziz,
ashraffouda,
muhamadazmy,
rawdaGastan and
xmonader
as code owners
ashraffouda
approved these changes
Jul 13, 2025
Signed-off-by: nabil salah <nabil.salah203@gmail.com>
ashraffouda
requested changes
Jul 17, 2025
| } | ||
|
|
||
| fn get_hub_url(runmode: &RunMode) -> Result<Vec<String>> { | ||
| let base_url = "https://github.com/threefoldtech/zos-config/raw/development_hub_array/"; |
Collaborator
There was a problem hiding this comment.
I already merged zos-config can u fix that?
also next time don't push temporary stuff if something depends on another pr make the second pr as draft until we merge the first one because this maybe merge by mistake w nlbs fel 7eet and no one notice
Signed-off-by: nabil salah <nabil.salah203@gmail.com>
ashraffouda
approved these changes
Jul 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes introduced by this PR and what does it affect
Changes
List of changes this PR includes
Related Issues
Checklist