Skip to content

Commit 178dbab

Browse files
committed
Fix NPM ECDSA CI: use committed yarn.lock instead of upgrading deps
The `yarn upgrade --exact` step pulls latest `development`-tagged npm packages which creates cross-dependency incompatibilities: - @threshold-network/solidity-contracts@1.3.0-dev.16 removed `approveApplication()` from TokenStaking source - @keep-network/random-beacon@2.1.0-dev.18 deploy script still calls it Replace with `yarn install --frozen-lockfile` to use the committed yarn.lock with known-compatible dependency versions.
1 parent 406d4d3 commit 178dbab

1 file changed

Lines changed: 2 additions & 6 deletions

File tree

.github/workflows/npm-ecdsa.yml

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -33,12 +33,8 @@ jobs:
3333
cache: "yarn"
3434
cache-dependency-path: solidity/ecdsa/yarn.lock
3535

36-
- name: Resolve latest contracts
37-
run: |
38-
yarn upgrade --exact \
39-
@keep-network/random-beacon \
40-
@keep-network/sortition-pools \
41-
@threshold-network/solidity-contracts
36+
- name: Install dependencies
37+
run: yarn install --frozen-lockfile
4238

4339
# Deploy contracts to a local network to generate deployment artifacts that
4440
# are required by dashboard and client compilation.

0 commit comments

Comments
 (0)