Skip to content

Commit 76f686a

Browse files
mswilkisonclaude
andcommitted
test(frost): state precisely what the real-cgo interactive test does not prove
Review caution (Codex): do not describe this as a full interactive e2e. Add an explicit note that it does NOT prove interactive round 2 or aggregate over the cgo session surface (those need >= 2 signers / multiple processes); it is a real-crypto round-1 / FFI-bridge / persisted-state integration test. Comment-only. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
1 parent 9934a63 commit 76f686a

1 file changed

Lines changed: 5 additions & 0 deletions

File tree

pkg/frost/signing/roast_real_cgo_interactive_e2e_frost_native_test.go

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,11 @@ import (
3939
// multi-member orchestration itself is covered with the fake engine over the real
4040
// transport in the runner net e2e.
4141
//
42+
// What this test does NOT prove: interactive round 2 or aggregate over the cgo
43+
// session surface (those need >= 2 signers, i.e. multiple processes). It is a
44+
// real-crypto round-1 / FFI-bridge / persisted-state integration test, not a full
45+
// interactive end-to-end signature.
46+
//
4247
// The DKG -> interactive keyGroup glue is RunDKG: InteractiveSessionOpen resolves
4348
// the signing key by a keyGroup IDENTIFIER (engine-internal persisted material),
4449
// not KeyPackage bytes. RunDKG runs the full DKG and PERSISTS the result, keyed by

0 commit comments

Comments
 (0)