refactor: streamline WalletRegistry test cases for clarity and consistency, enhancing readability and maintainability

Author: lionakhnazarov

solidity/ecdsa/.prettierignore

@@ -8,3 +8,4 @@ hardhat-dependency-compiler/
 typechain/
 docgen-templates/
 export.json
+gasReporterOutput.json

solidity/ecdsa/test/WalletRegistry.Slashing.test.ts

@@ -128,63 +128,66 @@ describe("WalletRegistry - Slashing", () => {
       context.skip(
         "when the passed wallet members identifiers are valid (skipped: TokenStaking slashing queue API differs from legacy tests)",
         () => {
-        let notifierBalanceBefore
-        let notifierBalanceAfter
+          let notifierBalanceBefore
+          let notifierBalanceAfter
 
-        before(async () => {
-          await createSnapshot()
+          before(async () => {
+            await createSnapshot()
 
-          notifierBalanceBefore = await tToken.balanceOf(thirdParty.address)
-          await walletRegistry
-            .connect(walletOwner.wallet)
-            .seize(
-              amountToSlash,
-              rewardMultiplier,
-              thirdParty.address,
-              walletID,
-              membersIDs
-            )
-          notifierBalanceAfter = await tToken.balanceOf(thirdParty.address)
-        })
-
-        after(async () => {
-          await restoreSnapshot()
-        })
-
-        it("should slash all group members", async () => {
-          expect(await staking.getSlashingQueueLength()).to.equal(
-            constants.groupSize
-          )
-        })
-
-        it("should slash with correct amounts", async () => {
-          for (let i = 0; i < constants.groupSize; i++) {
-            const slashing = await staking.slashingQueue(i)
-            expect(slashing.amount).to.equal(amountToSlash)
-          }
-        })
-
-        it("should slash correct staking providers", async () => {
-          for (let i = 0; i < constants.groupSize; i++) {
-            const slashing = await staking.slashingQueue(i)
-            const expectedStakingProvider =
-              await walletRegistry.operatorToStakingProvider(
-                membersAddresses[i]
+            notifierBalanceBefore = await tToken.balanceOf(thirdParty.address)
+            await walletRegistry
+              .connect(walletOwner.wallet)
+              .seize(
+                amountToSlash,
+                rewardMultiplier,
+                thirdParty.address,
+                walletID,
+                membersIDs
               )
+            notifierBalanceAfter = await tToken.balanceOf(thirdParty.address)
+          })
 
-            expect(slashing.stakingProvider).to.equal(expectedStakingProvider)
-          }
-        })
+          after(async () => {
+            await restoreSnapshot()
+          })
 
-        it("should send correct reward to notifier", async () => {
-          // Notification rewards are no longer configured in TokenStaking
-          // (pushNotificationReward/setNotificationReward methods removed).
-          // The notifier receives 0 reward.
-          const receivedReward = notifierBalanceAfter.sub(notifierBalanceBefore)
+          it("should slash all group members", async () => {
+            expect(await staking.getSlashingQueueLength()).to.equal(
+              constants.groupSize
+            )
+          })
+
+          it("should slash with correct amounts", async () => {
+            for (let i = 0; i < constants.groupSize; i++) {
+              const slashing = await staking.slashingQueue(i)
+              expect(slashing.amount).to.equal(amountToSlash)
+            }
+          })
+
+          it("should slash correct staking providers", async () => {
+            for (let i = 0; i < constants.groupSize; i++) {
+              const slashing = await staking.slashingQueue(i)
+              const expectedStakingProvider =
+                await walletRegistry.operatorToStakingProvider(
+                  membersAddresses[i]
+                )
+
+              expect(slashing.stakingProvider).to.equal(expectedStakingProvider)
+            }
+          })
+
+          it("should send correct reward to notifier", async () => {
+            // Notification rewards are no longer configured in TokenStaking
+            // (pushNotificationReward/setNotificationReward methods removed).
+            // The notifier receives 0 reward.
+            const receivedReward = notifierBalanceAfter.sub(
+              notifierBalanceBefore
+            )
 
-          expect(receivedReward).to.equal(0)
-        })
-      })
+            expect(receivedReward).to.equal(0)
+          })
+        }
+      )
 
       // TODO: Add a unit test ensuring `seize` call reverts if the staking
       // contract `seize` call reverts.