Commit a1585cc
committed
refactor(wallet-registry): remove stale NOT MIGRATED withdrawRewards test
The "NOT MIGRATED Touchpoints" describe block in
WalletRegistry.Authorization.test.ts asserted that withdrawRewards
retained TokenStaking beneficiary lookup post-initializeV2. With
withdrawRewards now routed through _currentAuthorizationSource(),
that invariant no longer holds. The test still passed because it
never invoked withdrawRewards -- it only read staking.rolesOf and
walletRegistry.allowlist() -- but its name, rationale comment, and
block-level documentation advertised behavior the code no longer
exhibits and would mislead future maintainers.
Positive coverage for post-upgrade Allowlist routing lives in
WalletRegistry.Rewards.test.ts ("withdrawRewards when allowlist !=
address(0)"). The top-of-file coverage summary is updated so the
remaining "NOT MIGRATED touchpoints" line continues to reflect the
still-valid slashing path (challengeDkgResult) without the removed
beneficiary claim.1 parent 0c6f839 commit a1585cc
1 file changed
Lines changed: 1 addition & 69 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3714 | 3714 | | |
3715 | 3715 | | |
3716 | 3716 | | |
3717 | | - | |
| 3717 | + | |
3718 | 3718 | | |
3719 | 3719 | | |
3720 | 3720 | | |
| |||
3975 | 3975 | | |
3976 | 3976 | | |
3977 | 3977 | | |
3978 | | - | |
3979 | | - | |
3980 | | - | |
3981 | | - | |
3982 | | - | |
3983 | | - | |
3984 | | - | |
3985 | | - | |
3986 | | - | |
3987 | | - | |
3988 | | - | |
3989 | | - | |
3990 | | - | |
3991 | | - | |
3992 | | - | |
3993 | | - | |
3994 | | - | |
3995 | | - | |
3996 | | - | |
3997 | | - | |
3998 | | - | |
3999 | | - | |
4000 | | - | |
4001 | | - | |
4002 | | - | |
4003 | | - | |
4004 | | - | |
4005 | | - | |
4006 | | - | |
4007 | | - | |
4008 | | - | |
4009 | | - | |
4010 | | - | |
4011 | | - | |
4012 | | - | |
4013 | | - | |
4014 | | - | |
4015 | | - | |
4016 | | - | |
4017 | | - | |
4018 | | - | |
4019 | | - | |
4020 | | - | |
4021 | | - | |
4022 | | - | |
4023 | | - | |
4024 | | - | |
4025 | | - | |
4026 | | - | |
4027 | | - | |
4028 | | - | |
4029 | | - | |
4030 | | - | |
4031 | | - | |
4032 | | - | |
4033 | | - | |
4034 | | - | |
4035 | | - | |
4036 | | - | |
4037 | | - | |
4038 | | - | |
4039 | | - | |
4040 | | - | |
4041 | | - | |
4042 | | - | |
4043 | | - | |
4044 | | - | |
4045 | | - | |
4046 | 3978 | | |
4047 | 3979 | | |
4048 | 3980 | | |
| |||
0 commit comments