ENG-469 Stabilize integration suites: Electrum skips, retries, env RPC, keep-common bump#3844
Open
piotr-roslaniec wants to merge 7 commits into
Open
ENG-469 Stabilize integration suites: Electrum skips, retries, env RPC, keep-common bump#3844piotr-roslaniec wants to merge 7 commits into
piotr-roslaniec wants to merge 7 commits into
Conversation
piotr-roslaniec
changed the title
piotr-roslaniec
changed the title
piotr-roslaniec
force-pushed
the
release/v2.3.1-rc
branch
2 times, most recently
from
56e8412 to
726ada4
Compare
piotr-roslaniec
force-pushed
the
release/v2.3.1-rc
branch
from
87b546c to
1922b3e
Compare
Local runs of go test -tags=integration ./... now skip rather than fail when ETHEREUM_MAINNET_RPC_URL is not configured. CI still sets the var, so behavior there is unchanged. Also clarify that blockByNumber returns a header-only block.
piotr-roslaniec
force-pushed
the
release/v2.3.1-rc
branch
from
1922b3e to
f0e09d4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stabilization patch for the v2.3.1-rc integration suites. Rebased onto current
main; superseded changes (WSS skip helper, sepolia peer refresh, direct keep-common version bump) have been dropped becausemainnow handles them.pkg/chain/ethereumto avoidtransaction type not supportederrors from upstream providers.ETHEREUM_MAINNET_RPC_URLfrom the environment inTestBaseChain_GetBlockNumberByTimestamp; skip (not fail) when unset so localgo test -tags=integration ./...stays friendly. CI sets the secret.ETHEREUM_MAINNET_RPC_URLinto the integration job in.github/workflows/client.yml.*2→*6) to absorb slower public endpoints.fmt.Errorfwitherrors.Newinpkg/tbtcpg/internal/test/marshaling.goso the unmarshaled error string is not interpreted as a format directive.Testing
go vet ./pkg/chain/ethereum/... ./pkg/bitcoin/electrum/... ./pkg/tbtcpg/...go test ./config(unchanged on this branch)go test -tags=integration ./pkg/bitcoin/electrum(electrs retries extended)go test -tags=integration ./pkg/chain/ethereumwithETHEREUM_MAINNET_RPC_URLsetgo test -v ./pkg/tbtcpg/internal/testFollow-ups (not in this PR)
ethereum_integration_test.go(f41c6e3d505d44c182a5e5adefdaa43f) is still reachable viagit log. Rotate it in the Infura dashboard.blockByNumberis now functionally equivalent toheaderByNumber. Collapse post-release.Closes ENG-469.