docs(tbtc/signer): Phase 7.0 sidecar transport addendum#4050
Merged
mswilkison merged 2 commits intoJun 13, 2026
Merged
Conversation
Maps the frozen interactive-session API onto the sidecar process boundary from Decision Log entry 2 and scopes what that boundary means for the decision-gated #4007 TEE checker stack. Key points: the coarse JSON request/response contract was chosen for exactly this swap, and the frozen spec's engine-held nonce custody dissolves the old decision-brief objection to round-level APIs - rounds cross the boundary, nonces do not. Decision 7's init-config demand semantics carry over unchanged with "sidecar unreachable" joining the same fatal failure family; a sidecar crash is exactly the markers-only restart story, introducing no new failure mode. Security boundary: owner-only UDS with peer-credential pinning, never a network listener; the state-key provider moves to the sidecar's process environment. Transport-parameterized conformance tests are the mechanism keeping "transport swap, not API rework" true. The sidecar track (7.S1-7.S3) runs parallel to 7.1-7.5 and must converge before the ECDSA-retirement phases. Four open questions with proposed defaults (spawn model, framing, connection model, packaging) for sign-off. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Section 1 said the host "holds no signing secrets at any time," but section 3 maps the transitional DKG calls unchanged and the frozen Phase 7 spec still has the DKG APIs returning/accepting secret_package_hex through the host until the DKG-custody follow-up. So in deployments that run DKG through this transport the host still sees DKG secret material (review finding). Section 1 now scopes the property to the signing path and states explicitly that #4007 must treat the host<->sidecar signing interface as a secret boundary but NOT the DKG interface until DKG custody moves inside the sidecar - a precondition for the sidecar being a complete secret boundary. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
472dfa6
into
extraction/frost-signer-mirror-2026-05-26
19 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The outstanding 7.0 item from the frozen Phase 7 spec (§9): maps the frozen §5 session API onto the sidecar process boundary (Decision Log entry 2) and scopes #4007's TEE checker stack against it. Doc-only; by construction it changes no contract — anything in it that would alter the frozen spec is a defect in the addendum.
Highlights
TBTC_SIGNER_INIT_CONFIG_PATHset, a sidecar that can't spawn, can't handshake, or rejects the config is process-fatal for the host — "sidecar unreachable" joins the existing fatal failure family at the same enforcement point.Open questions for sign-off (§8, proposed defaults)
(a) spawn model: keep-client child process; (b) framing: length-prefixed JSON; (c) connection model: pool with one in-flight request per connection; (d) packaging: same release artifact.
🤖 Generated with Claude Code