-
Notifications
You must be signed in to change notification settings - Fork 66
ENG-472 Bridge controller pointer and MintBurnGuard guardrails #918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
piotr-roslaniec
wants to merge
82
commits into
main
Choose a base branch
from
new/bank-decreaser
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
82 commits
Select commit
Hold shift + click to select a range
da0c4dc
feat: extend bank balance authorization
piotr-roslaniec c7bf48a
docs: add Bridge controller-authorization upgrade explainer; ignore l…
piotr-roslaniec 0f5f209
deploy(upgrade-bridge): prefer cached deployment, use PROXY_ADMIN_PK …
piotr-roslaniec 3cb3a0a
deploy(transfer-governance): use governance signer (BRIDGE_GOVERNANCE…
piotr-roslaniec 20a8e8f
scripts(sepolia): call BridgeGovernance ownership transfer; fix rollb…
piotr-roslaniec 2c777b0
config(hardhat): set optimizer runs to 200; update comments and keep …
piotr-roslaniec 1976be0
deploy(governance): conditional Tenderly/Etherscan verify and minor p…
piotr-roslaniec 9d56c1b
chore(docs): format bridge upgrade explainer with Prettier
piotr-roslaniec 8969dac
chore(solidity): relax lint for deploy/scripts via overrides; fix typ…
piotr-roslaniec 766a6d0
Sepolia: redeploy BridgeGovernance and verify allowlist
piotr-roslaniec c92f50a
Remove unused solidity .env example
piotr-roslaniec d74bb6b
Remove Sepolia-specific upgrade/rollback scripts
piotr-roslaniec 38159ee
Revert "Sepolia: redeploy BridgeGovernance and verify allowlist"
piotr-roslaniec 5dec1e5
Remove toggle-increaser helper script
piotr-roslaniec 1cf6301
Remove verify-sepolia helper script
piotr-roslaniec 66ec3bd
chore(governance): helper + safer controller sync
piotr-roslaniec 1aa5af7
docs: consolidate controller upgrade and governance redeploy
piotr-roslaniec b3d4f0a
docs: remove redundant bridge governance redeploy report
piotr-roslaniec c729bc9
solidity: switch git+ssh deps to git+https
piotr-roslaniec 874500c
ci(contracts): use node 18 for solidity jobs
piotr-roslaniec 64aa9e7
ci(contracts): align format/slither with node 18
piotr-roslaniec 3fc56bb
ci(contracts): move solidity jobs to node 20
piotr-roslaniec 1c80f74
chore(governance): controller ops tooling and docs
piotr-roslaniec dc44a82
chore(solidity): apply Prettier formatting
piotr-roslaniec 0312bab
chore(solidity): align hardhat and deploy tooling with main
piotr-roslaniec 3369741
chore(solidity): revert unrelated contract formatting
piotr-roslaniec 09e95dd
Fix bridge governance CI and formatting
piotr-roslaniec c460c8d
Use Node 18 for contracts CI
piotr-roslaniec eb6fa37
chore(governance): harden controller sync and tooling
piotr-roslaniec f5773f7
ci(docs): ignore engines for solidity docs workflow
piotr-roslaniec 33993a4
ci(docs): set YARN_IGNORE_ENGINES at workflow level
piotr-roslaniec e5991a3
ci(contracts): run format job on node 18 and ignore generated docs
piotr-roslaniec 52a01d7
feat(bridge): controller caps and MintingGuard scaffold
piotr-roslaniec 1b9d275
refactor(bridge): rely on MintingGuard for caps
piotr-roslaniec 4831a07
Wire MintingGuard executor and docs for controller allowlist
piotr-roslaniec 1d01c9f
test: relax MintingGuard revert assertions
piotr-roslaniec 3fc3497
slither: silence expected reentrancy warnings for controllers
piotr-roslaniec f4b94c8
slither: widen controller reentrancy suppression
piotr-roslaniec 8a4c28b
refactor: emit controller events before bank calls
piotr-roslaniec a3ac589
Wire MintBurnGuard interface, tests, and docs
piotr-roslaniec 682bb52
chore: rename MintingGuard to MintBurnGuard
piotr-roslaniec 7ccab01
chore: switch bridge to single controller
piotr-roslaniec 593b0a9
fix: share vault interface and satisfy slither
piotr-roslaniec b72596f
refactor: keep vault interface local
piotr-roslaniec 505b08a
Use ITBTCVault in MintBurnGuard and fix lints
piotr-roslaniec af0d715
Improve execution wiring and governance transfer workflow
piotr-roslaniec d5c995e
Allow internal wiring helpers
piotr-roslaniec 963b24a
refactor: reuse guard increase logic
piotr-roslaniec d911874
Add configurable mint rate limiting to MintBurnGuard
piotr-roslaniec 44468af
Suppress time-based lint for MintBurnGuard rate limit
piotr-roslaniec a15a87e
Document MintBurnGuard rate limiting
codex fdfa279
fix(mintburn): avoid window start equality
piotr-roslaniec 7a69404
Merge remote-tracking branch 'origin/main' into new/bank-decreaser
piotr-roslaniec 41d7a8e
fix(mintburnguard): address audit findings ENG-473
piotr-roslaniec 3526421
Merge branch 'main' into feat/eng-472-mintburnguard-workstream
miquelcabot a1fa407
Implement one-off governance function setControllerBalanceIncreaser
miquelcabot c1a1195
refactor: rename controller-related interfaces, functions and events
miquelcabot fe7d9af
refactor: update MintBurnGuard to use 'operator' terminology instead …
miquelcabot 76a2869
feat: implement MintBurnGuard deployment and configuration scripts
miquelcabot 1b794d2
refactor: add unmintAndBurnFrom and burnFrom functions to MintBurnGuard
miquelcabot 764ea30
refactor: enhance unmintAndBurnFrom and burn functions with SafeERC20…
miquelcabot 1281655
refactor: add error handling for bank transfer failure in MintBurnGuard
miquelcabot b2aaf13
test: add operator change functionality tests in MintBurnGuard
miquelcabot 89c6cd1
refactor: rename controller to operator in MintBurnGuard tests
miquelcabot 08407c1
feat: implement MockAccountControl for testing MintBurnGuard integration
miquelcabot f5bc30d
feat: add bank and tbtcToken addresses for improved vault integration…
miquelcabot cee32f0
refactor: change TBTC token approval to use safeIncreaseAllowance in …
miquelcabot 158a8d1
fix: update balance handling in MintBurnGuard to use satoshi (1e8) am…
miquelcabot 3675843
Merge branch 'main' into new/bank-decreaser
miquelcabot 5bc750e
Merge branch 'new/bank-decreaser' into feat/eng-472-mintburnguard-wor…
miquelcabot 0d0613a
feat: add bridge address to MintBurnGuard for improved vault integration
miquelcabot e9913cb
feat: refactor MintBurnGuard to use upgradeable proxy pattern and add…
miquelcabot 2533910
feat: update Slither version to 0.10.1
miquelcabot a5dcc8a
feat: update Slither version to 0.11.0
miquelcabot d0be3d8
feat: add 'incorrect-equality' to Slither detectors to exclude
miquelcabot 6b56b55
feat: update Slither command to fail on high severity issues
miquelcabot b7b33f4
feat: add integration tests for MintBurnGuard contract interactions
miquelcabot ff9e4f2
ENG-472: MintBurnGuard workstream. Governance, interfaces, integratio…
piotr-roslaniec 6ba652b
fix(bridge): re-upgrade Bridge proxy to MintBurnGuard-aware impleme…
antomor 6452b75
fix(deploy): TOB-TBTCAC-45: enforce strict library bytecode verificat…
piotr-roslaniec eecfc53
fix(deploy): TOB-TBTCAC-45: enforce strict library bytecode verificat…
piotr-roslaniec 29fcc68
chore: merge main into new/bank-decreaser
piotr-roslaniec File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.