Skip to content

Data producer paragraph_behavior is broken with NULL default value #906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mrmishmash wants to merge 4 commits into
base: 7.4.x
Choose a base branch
from
Open

Data producer paragraph_behavior is broken with NULL default value #906

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
204518a
Fixes paragraph_behavior data producer plugin by making default value…
mihawagner Sep 7, 2025
2581c67
Fixes phpcs issues.
mihawagner Sep 7, 2025
9e6df1c
Change existing kernel test instead of implementing unit test.
mihawagner Sep 7, 2025
e7d7990
Fixes phpcs issues.
mihawagner Sep 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions modules/thunder_gqls/src/Plugin/GraphQL/DataProducer/ParagraphBehavior.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,15 @@
* label = @Translation("Paragraphs behavior plugin key")
* ),
* "behavior_plugin_default" = @ContextDefinition("any",
* label = @Translation("Paragraphs behavior plugin default for this key")
* label = @Translation("Paragraphs behavior plugin default for this key"),
* required = FALSE,
* default_value = NULL,
* ),
* "throw_on_missing_plugin" = @ContextDefinition("boolean",
* label = @Translation("Whether to throw if behaviour plugin is not enabled"),
* required = FALSE,
* default_value = TRUE,
* )
* }
* )
*/
Expand All @@ -44,17 +51,24 @@ class ParagraphBehavior extends DataProducerPluginBase {
* Key for requested value of this paragraph behavior plugin.
* @param mixed $behavior_plugin_default
* Provided default value for requested key or NULL.
* @param bool $throw_on_missing_plugin
* Whether to throw if behaviour plugin is not enabled.
*
* @return mixed
* Value of this paragraph behavior plugin key.
*
* @throws \Exception
*/
public function resolve(ParagraphInterface $paragraph, string $behavior_plugin_id, string $behavior_plugin_key, $behavior_plugin_default = NULL) {
public function resolve(ParagraphInterface $paragraph, string $behavior_plugin_id, string $behavior_plugin_key, mixed $behavior_plugin_default = NULL, bool $throw_on_missing_plugin = TRUE): mixed {
if ($paragraph->getParagraphType()->hasEnabledBehaviorPlugin($behavior_plugin_id)) {
return $paragraph->getBehaviorSetting($behavior_plugin_id, $behavior_plugin_key, $behavior_plugin_default);
}
throw new \Exception('Not enabled or invalid paragraphs behavior plugin.');

if ($throw_on_missing_plugin) {
throw new \Exception('Not enabled or invalid paragraphs behavior plugin.');
}

return $behavior_plugin_default;
}

}
6 changes: 3 additions & 3 deletions modules/thunder_gqls/tests/src/Kernel/DataProducer/ParagraphsBehaviorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,9 @@ public function testBehaviorSettings(): void {
'paragraph' => $paragraph,
'behavior_plugin_id' => 'test_text_color',
'behavior_plugin_key' => 'text_color',
'behavior_plugin_default' => 'blue',
'behavior_plugin_default' => NULL,
]);
$this->assertEquals('blue', $result);
$this->assertNull($result);

// Create a paragraph and set its feature settings.
$paragraph = Paragraph::create([
Expand All @@ -81,7 +81,7 @@ public function testBehaviorSettings(): void {
'paragraph' => $paragraph,
'behavior_plugin_id' => 'test_text_color',
'behavior_plugin_key' => 'text_color',
'behavior_plugin_default' => 'blue',
'behavior_plugin_default' => NULL,
]);

// Now we should not get the default value.
Expand Down