fix(notifications): respect showContactPicture setting for notification avatars

[mvanhorn]

Summary

When contact pictures are disabled in the message list settings, notification avatars are still shown. This checks the isShowContactPicture preference before loading contact avatars for new mail notifications.

Why this matters

PR #9652 added avatar support to notifications but didn't check the existing contact picture visibility setting. Users who disable contact pictures in the message list expect notifications to also respect that preference.

Changes

• SingleMessageNotificationCreator.kt: Added MessageListPreferencesManager as a constructor dependency and an early return in setAvatar() when isShowContactPicture is false (line 68)
• CoreNotificationKoinModule.kt: Injected messageListPreferencesManager into SingleMessageNotificationCreator

Testing

• Verified the preference check reads from the same showContactPicture key used by the message list UI (MessageViewHolder.kt:63)
• When isShowContactPicture is false, setAvatar() returns without loading or setting the large icon
• When isShowContactPicture is true (default), behavior is unchanged

Fixes #10750

This contribution was developed with AI assistance (Claude Code).

[github-actions]

Missing report label. Set exactly one of: report: include, report: exclude OR report: highlight.

[rafaeltonholo]

Hi @mvanhorn,

Thank you for taking the time to work on this PR.

While your current change allows users to enable or disable the Avatar in notifications, the configuration you're using is incorrect.

The MessageListPreferencesManager is meant for the Message List screen, not for Notifications. There may be instances where users prefer not to have Avatars displayed in notifications but still want to see them in the Message List, and vice versa.

To properly address issue #10750, we should add a new user preference under NotificationPreference. This would allow users to disable Avatars specifically for notifications.

For reference, you can look at commit 8dfa32e, which demonstrates how to add a new Boolean preference using the NotificationPreferenceManager.

Thank you!

[mvanhorn]

Thanks for the review, @rafaeltonholo. Reworked this in d847439 to use a dedicated NotificationPreference value instead of the message-list contact picture preference.

Changes:

• Added isShowContactPictureInNotification to NotificationPreference (defaults to true to preserve current behavior).
• Persisted via KEY_SHOW_CONTACT_PICTURE_IN_NOTIFICATION in DefaultNotificationPreferenceManager.
• SingleMessageNotificationCreator.setAvatar() now reads from NotificationPreferenceManager instead of MessageListPreferencesManager.
• Added a separate "Show contact pictures in notifications" toggle in general settings, alongside the existing notification preferences.
• Pattern mirrors commit 8dfa32e you referenced.
• Added focused unit coverage (SingleMessageNotificationCreatorTest) for both branches of the new preference.

Force-pushed to replace the original commit since the underlying approach changed.

[rafaeltonholo]

LGTM, please, just update your branch with the latest main version, so we can get rid of the CI failure.

[mvanhorn]

Thanks for the approval @rafaeltonholo. Rebased onto current main (172694b on top of fb1baad) and force-pushed. The diff is unchanged.

The require-report-label check is gated on a report: include/report: exclude/report: highlight label that I can't add as a non-maintainer; if you can drop one of those on the PR I think the rest of the gate clears.

[rafaeltonholo]

Thanks for the approval @rafaeltonholo. Rebased onto current main (172694b on top of fb1baad) and force-pushed. The diff is unchanged.

The require-report-label check is gated on a report: include/report: exclude/report: highlight label that I can't add as a non-maintainer; if you can drop one of those on the PR I think the rest of the gate clears.

I've placed the label already; you should be good now. Once the CI finishes, we can merge these changes! Thanks for this contribution!

[thunderbird-botmobile]

Thanks for your contribution! Your pull request has been merged and will be part of Thunderbird 20. We appreciate the time and effort you put into improving Thunderbird. If you haven’t already, you’re welcome to join our Matrix chat for contributors. It’s where we discuss development and help each other out. https://matrix.to/#/#tb-android-dev:mozilla.org
Hope to see you there! 🚀📱🐦