fix: allow scrolling the notification actions list on small screens#11212
Open
mvanhorn wants to merge 1 commit into
Open
fix: allow scrolling the notification actions list on small screens#11212mvanhorn wants to merge 1 commit into
mvanhorn wants to merge 1 commit into
Conversation
Move the reorder drag gesture from the full row onto a dedicated leading drag handle so vertical drags elsewhere on a row fall through to the LazyColumn and scroll the list. The handle is decorative for accessibility; screen-reader reordering stays on the existing up/down buttons. Fixes thunderbird#11191.
Contributor
|
✅ Validation Passed: All report and feature-flag labels are correctly set. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Prior to submitting a pull request, please familiarize yourself with...
Linked Issue/Ticket: Fixes #11191
Description
On the Notification actions reorder screen, every row attached a full-row drag gesture.
NotificationReorderRowinNotificationActionsSettingsScreen.ktput.immediateDragGesture(...)on the rootRow, so any vertical drag anywhere on a row was consumed as a reorder drag. When the action list is taller than the screen, that left no way to scroll theLazyColumn, and actions below the fold were unreachable on small displays.This moves the gesture off the row and onto a dedicated leading drag handle (
NotificationDragHandle). With the gesture confined to the handle, vertical drags on the rest of a row fall through to theLazyColumnand scroll the list, while dragging the handle still reorders the item. This mirrors how account reordering already exposes a grab area in settings.The reorder logic in
NotificationActionsReorderControlleris unchanged. The existing up/down arrow buttons remain the accessible reordering path, so the handle is marked decorative for screen readers (clearAndSetSemantics) to avoid exposing a repeated, non-actionable element to TalkBack.Screen Shots
This is a touch-gesture and behavior change. A short video of dragging the handle versus scrolling the row body would best show it; I was not able to capture device media in this environment.
AI Disclosure
Select one of the following (mandatory)
Please ensure that your pull request meets the following requirements - thanks!
gradlew spotlessCheckto check andgradlew spotlessApplyto format your source code; will be checked by CI).gradlew testDebugUnitTest; will be checked by CI).AI was used for assistance.