refactor: change account color handling#10048
Closed
wmontwe wants to merge 5 commits into
Closed
Conversation
wmontwe
force-pushed
the
fix/9031/change-account-color-handling
branch
5 times, most recently
from
c9efb7e to
8d64a96
Compare
rafaeltonholo
added
the
merge block: soft freeze
wmontwe
force-pushed
the
fix/9031/change-account-color-handling
branch
from
8d64a96 to
ac4321c
Compare
…cy theme dependency
wmontwe
force-pushed
the
fix/9031/change-account-color-handling
branch
from
ac4321c to
5456201
Compare
wmontwe
removed
the
merge block: soft freeze
Member
Author
|
Close in favor of #10104 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #9031
This refactors the account color picking logic to use the new
AccountProfileRepositoryand an immutable account color list and improves dependency injection setup. The color picking logic now ensures colors are distributed as evenly as possible among accounts. Rendering thedefault_account_colorsobsolete.It also introduces documentation for the
Outcometype.