Add folder expand option#10077
Conversation
shamim-emon
force-pushed
the
fix-issue-10036
branch
4 times, most recently
from
bce5764 to
a73a98a
Compare
|
@shamim-emon Could I make a suggestion to change the description of setting "Auto-Expand Folder" found under settings > account > folders, to avoid confusion with settings your PR will introduce. The setting's name I mention is already ambiguous. It seems to define the default folder selected after switching account view, rather than expanding any folder. |
@platform34 thanks for pointing it out. I updated the title for your mentioned setting, so that it is more appropriate with it's usage. |
rafaeltonholo
added
the
merge block: soft freeze
wmontwe
removed
the
merge block: soft freeze
shamim-emon
force-pushed
the
fix-issue-10036
branch
3 times, most recently
from
9d7d34b to
15fbb4a
Compare
rafaeltonholo
left a comment
rafaeltonholo
left a comment
There was a problem hiding this comment.
LGTM! I've just left a few comments for your consideration, but feel free to merge it without addressing them.
| @@ -239,7 +239,7 @@ | |||
| <com.fsck.k9.ui.settings.account.FolderListPreference | |||
| android:key="account_setup_auto_expand_folder" | |||
There was a problem hiding this comment.
We should also rename the key to better fit with the new title. However, this can be done in a follow-up ticket.
There was a problem hiding this comment.
Thank you for your suggestion. I would prefer to do this in a follow-up ticket.
…ntract.kt and expose it to UI to control initial collapsed/expanded state of side menu folders
… to be toggled from General Settings → Display Settings section
…AllFolder' setting`
shamim-emon
force-pushed
the
fix-issue-10036
branch
from
4d76759 to
123c306
Compare
shamim-emon
temporarily deployed
to
botmobile
GitHub Actions
Inactive
rafaeltonholo
temporarily deployed
to
botmobile
GitHub Actions
Inactive
4 participants
🧩 Summary
This PR introduces a new general setting called
drawerExpandAllFolder, allowing users to control whether folders in the navigation drawer are expanded or collapsed by default.🛠️ Changes
drawerExpandAllFolderto the app’s settings system.DrawerContractand the related UI components to determine the initial expanded/collapsed state of side-menu folders.🎯 Impact
Users can now personalize how their folder drawer behaves on startup, improving the customization and usability of the app’s navigation experience.