Skip to content

feat(account-setting): add account monogram customization part 3#10104

Merged
wmontwe merged 25 commits into
thunderbird:mainfrom
wmontwe:feat/9031/add-account-monogram-customization-part-3
Nov 20, 2025
Merged

feat(account-setting): add account monogram customization part 3#10104
wmontwe merged 25 commits into
thunderbird:mainfrom
wmontwe:feat/9031/add-account-monogram-customization-part-3

Conversation

@wmontwe
Copy link
Copy Markdown
Member

@wmontwe wmontwe commented Nov 13, 2025 •
edited
Loading

Resolves #9031

@wmontwe wmontwe requested a review from a team as a code owner November 13, 2025 14:48
@wmontwe wmontwe added merge block: soft freeze PR to main is blocked: risky code or feature flag enablement must wait until soft freeze lifts. and removed merge block: soft freeze PR to main is blocked: risky code or feature flag enablement must wait until soft freeze lifts. labels Nov 13, 2025
rafaeltonholo
rafaeltonholo reviewed Nov 14, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@rafaeltonholo rafaeltonholo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution! I've left a few comments I would like to discuss before approving this.

Comment thread app-common/src/main/kotlin/net/thunderbird/app/common/account/AccountColorPicker.kt
Comment thread app-common/src/main/kotlin/net/thunderbird/app/common/account/AppCommonAccountModule.kt
Comment thread .../validation/src/commonMain/kotlin/net/thunderbird/core/validation/input/IntegerInputField.kt
Comment thread ...n/kotlin/net/thunderbird/core/ui/setting/dialog/ui/components/dialog/value/TextDialogView.kt
Comment thread ...n/kotlin/net/thunderbird/core/ui/setting/dialog/ui/components/dialog/value/TextDialogView.kt
Comment thread ...in/kotlin/net/thunderbird/feature/account/settings/impl/domain/usecase/GetGeneralSettings.kt Outdated
Comment thread ...n/kotlin/net/thunderbird/feature/account/settings/impl/domain/usecase/ValidateAccountName.kt Outdated
Comment thread ...src/main/kotlin/net/thunderbird/feature/account/settings/impl/ui/general/GeneralSettingId.kt
Comment thread ...in/kotlin/net/thunderbird/feature/account/settings/impl/ui/general/GeneralSettingsBuilder.kt
Comment thread ...n/kotlin/net/thunderbird/feature/navigation/drawer/dropdown/ui/common/DisplayAccountUtils.kt
This was referenced Nov 14, 2025
Closed
Closed
Closed
@wmontwe wmontwe force-pushed the feat/9031/add-account-monogram-customization-part-3 branch from ad5fe63 to dd2314a Compare November 19, 2025 13:15
rafaeltonholo
rafaeltonholo previously approved these changes Nov 19, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@rafaeltonholo rafaeltonholo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wmontwe
Copy link
Copy Markdown
Member Author

wmontwe commented Nov 20, 2025

The mdbook failure is fixed in #10121, will update this PR once merged.

wmontwe added 14 commits November 20, 2025 14:06
@wmontwe
docs: add documentation for Outcome
4378c98
@wmontwe
refactor: change feature:account:core module to kmp
dd3e629
@wmontwe
feat(account): add getAll to AccountProfileRepository
4c6e31f
@wmontwe
feat(account): inject account colors
62f0a7c
@wmontwe
refactor(account-setting): use injected account colors to remove lega…
13823c5 
…cy theme dependency
@wmontwe
refactor(account-setting): rename SettingsError to AccountSettingError
a7ae92f
@wmontwe
refactor(account-setting): change update use case to command pattern
72c46f9
@wmontwe
feat(account-setting): add account name and avatar validators
8e7a819
@wmontwe
feat(core-validation): add integer input field
e4169cf
@wmontwe
refactor(account-setting): change the init to launchIn
894d67d
@wmontwe
refactor(account-setting): remove GeneralPreference and move settings…
5ff50b1 
… from GetGeneralSettings to GeneralSettingsBuilder
@wmontwe
feat(account-settind): add account avatar monogram customization
18b35e6
@wmontwe
fix(core-setting): item should expand to full width
540a994
@wmontwe
refactor(account-avatar): rename AccountAvatar to Avatar and move to …
03b4061 
…account:avatar:api module
wmontwe added 11 commits November 20, 2025 14:06
@wmontwe
feat(account-avatar): add account avatar with monogram support
19c08ce
@wmontwe
refactor(account-storage): rename AccountAvatarDataMapper to AvatarDa…
e99ef9a 
…taMapper
@wmontwe
feat(drawer): add avatar support
2bbab70
@wmontwe
feat(account-settings): add transform to SettingValue.Text to allow c…
e90a209 
…hanges to the input
@wmontwe
feat(account-settig): add account name and monogram validation support
cb1155f
@wmontwe
refactor(account-avatar): rename profile indicator to avatar
5068539
@wmontwe
feat(account-setting): add description for the avatar selection and m…
b8036f8 
…onogram
@wmontwe
refactor(account-settings): rename GetGeneralSettings to GetAccountPr…
08e32ec 
…ofile
@wmontwe
feat(account-settings): add link to RFC for account name validation
23b25f3
@wmontwe
refactor(account-settings): remove redundant text transform
678d4c0
@wmontwe
chore(build): change :feature:account:core to new kmp plugin
c9cd5ee
@wmontwe wmontwe force-pushed the feat/9031/add-account-monogram-customization-part-3 branch from bb829e0 to c9cd5ee Compare November 20, 2025 13:32
rafaeltonholo
rafaeltonholo approved these changes Nov 20, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@rafaeltonholo rafaeltonholo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@wmontwe wmontwe merged commit 602d6e0 into thunderbird:main Nov 20, 2025
14 checks passed
@wmontwe wmontwe deleted the feat/9031/add-account-monogram-customization-part-3 branch November 20, 2025 15:24
@thunderbird-botmobile thunderbird-botmobile Bot added this to the Thunderbird 16 milestone Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rafaeltonholo rafaeltonholo rafaeltonholo approved these changes

Assignees

@rafaeltonholo rafaeltonholo

Labels

None yet

Projects

None yet

Milestone

Thunderbird 16

Development

Successfully merging this pull request may close these issues.

Account Settings - Account Monogram customization

2 participants

@wmontwe @rafaeltonholo