Skip to content

feat(merge-prs-report): include feature flag information in the merge prs report#10843

Open
rafaeltonholo wants to merge 5 commits intothunderbird:mainfrom
rafaeltonholo:feat/add-feature-flag-to-merged-prs-report
Open

feat(merge-prs-report): include feature flag information in the merge prs report#10843
rafaeltonholo wants to merge 5 commits intothunderbird:mainfrom
rafaeltonholo:feat/add-feature-flag-to-merged-prs-report

Conversation

@rafaeltonholo
Copy link
Copy Markdown
Member

@rafaeltonholo rafaeltonholo commented Apr 9, 2026

  • Extract the feature-flag from PR's body when the label feature flag is present
  • Change the .editorconfig, adding the indent_size of 2 for sh
  • Add merge reports to the .gitignore

@rafaeltonholo rafaeltonholo requested review from a team as code owners April 9, 2026 14:41
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 9, 2026

Missing report label. Set exactly one of: report: include, report: exclude OR report: highlight.

@github-actions github-actions bot added the tb-team Tasks and features handled by project maintainers label Apr 9, 2026
@rafaeltonholo rafaeltonholo requested a review from wmontwe April 9, 2026 14:41
@rafaeltonholo rafaeltonholo removed the request for review from jbott-tbird April 9, 2026 14:41
@rafaeltonholo rafaeltonholo added the feature-flag Changes guarded by a feature flag. Please add a comment stating the name: "feature-flag: abc" label Apr 9, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 9, 2026

Missing report label. Set exactly one of: report: include, report: exclude OR report: highlight.

@rafaeltonholo rafaeltonholo added report: include Include changes in user-facing reports. report: exclude Exclude changes from user-facing reports (internal, minor, or not relevant to users). and removed report: include Include changes in user-facing reports. feature-flag Changes guarded by a feature flag. Please add a comment stating the name: "feature-flag: abc" labels Apr 9, 2026
wmontwe
wmontwe previously approved these changes Apr 10, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@wmontwe wmontwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wmontwe wmontwe assigned wmontwe and unassigned rafaeltonholo Apr 13, 2026
@wmontwe wmontwe requested a review from coreycb April 13, 2026 10:08
coreycb
coreycb requested changes Apr 13, 2026
View reviewed changes
Comment thread scripts/merged-pr-report.sh Outdated
@rafaeltonholo rafaeltonholo force-pushed the feat/add-feature-flag-to-merged-prs-report branch from f5d99c3 to f16794b Compare April 13, 2026 13:56
@rafaeltonholo rafaeltonholo requested a review from wmontwe April 13, 2026 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coreycb coreycb coreycb approved these changes

@wmontwe wmontwe Awaiting requested review from wmontwe

At least 1 approving review is required to merge this pull request.

Assignees

@coreycb coreycb

@wmontwe wmontwe

Labels

report: exclude Exclude changes from user-facing reports (internal, minor, or not relevant to users). tb-team Tasks and features handled by project maintainers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rafaeltonholo @coreycb @wmontwe @jbott-tbird