chore(10778): add legacy support for footer updates and trigger effects on footer click#10886
Open
rafaeltonholo wants to merge 20 commits intothunderbird:mainfrom
Open
chore(10778): add legacy support for footer updates and trigger effects on footer click#10886rafaeltonholo wants to merge 20 commits intothunderbird:mainfrom
rafaeltonholo wants to merge 20 commits intothunderbird:mainfrom
Conversation
… in MessageListViewModel
Update `SortCriteriaMenuList` to use the current account ID when dispatching sort criteria changes, ensuring settings are applied per-account rather than globally. This also adds a check to exclude `UnifiedAccountId` when determining the account ID.
Implemented message focus tracking and updated `MessageListFragment` to use the focused message for keyboard/contextual actions. - Added `focusedMessage` to `MessageListMetadata` and corresponding focus events to `MessageItemEvent`. - Updated `MessageListScreenRenderer` to dispatch focus enter/exit events. - Refactored `MessageListFragment` to use `focusedMessage` for delete, archive, move, copy, and flag toggle operations. - Implemented `toggleMessageSelect` logic using the view model state.
- Added `OpenMessage` effect to `MessageListEffect`. - Created `OpenMessageSideEffect` to handle message click events and dispatch the open message effect. - Updated `SetupLoadedMessagesState` to set active message on message click. - Integrated `OpenMessageSideEffect` in `MessageListSideEffectsModule`. - Updated `MessageListFragment` to handle `OpenMessage` effect and open the message.
… mode - Added `ToggleMessageSideEffect` to handle message click events in selecting mode and dispatch toggle select event. - Updated `SetupSelectingMessagesState` to toggle message selection state on click. - Integrated `ToggleMessageSideEffect` in `MessageListSideEffectsModule`.
…age updates - Created `SetMessageActiveSideEffect` to handle `SetMessageActive` events and scroll to the newly active message - Updated `SetupLoadedMessagesState` to mark messages as active/inactive in the message list on click and active state changes - Added `mapMessages()` utility to `MessageListState` for transforming message lists while preserving state type - Fixed message scrolling comparison to use message IDs instead of object equality - Replaced `LifecycleStartEffect` with `collectAsStateWithLifecycle` for scroll event collection - Integrated `SetMessageActiveSideEffect` in `MessageListSideEffectsModule`
- Changed visibility of `MessageListScreenAccessibilityState` and `rememberMessageListScreenAccessibilityState` to internal - Changed visibility of side effect classes to internal: `SetMessageActiveSideEffect`, `LoadPreferencesSideEffect`, `ToggleMessageSideEffect`, `ChangeSortCriteriaSideEffect`, `AllConfigurationsReadySideEffect`, `OpenMessageSideEffect`, `LoadSwipeActionsStateSideEffectHandler`, `LoadSortCriteriaStateSideEffectHandler`, `LoadFolderInformationSideEffect` - Changed visibility of `DefaultLocalDeleteOperationDecider` and `MessageListViewModel` to internal
…r effects on footer click
rafaeltonholo
added
report: exclude
github-actions
bot
added
the
tb-team
rafaeltonholo
requested review from
dani-zilla
and removed request for
jbott-tbird
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #10778
Depends on #10863
feature-flag:
enable_message_list_new_stateCommits on this PR
Summary
BaseStateMachineViewModel.onEventWithoutStateModificationfor events that could trigger a ui side effect without changing the stateScreen Recording
Screen.Recording.2026-04-16.at.3.04.19.PM.mp4