Refactor: Move legacy:search to feature:search#9010
Conversation
eb78553 to
9ace541
Compare
9ace541 to
8a73c76
Compare
|
@asoucar here are some of the refactorings Shamim and Wolf have been working on. We're aiming to make the modules in the feature directory fairly self-contained, to reduce dependencies and build time. What goes into the feature modules should be "the way things are intended to be". The account object is very broadly (and sometimes wrongly) used, so we need to be careful on how dependencies work here. This is a bit over my head to really review well, if this is straightforward to you then feel free to take a look. |
asoucar
left a comment
There was a problem hiding this comment.
I had the one actual code question but otherwise the code looks fine and like it would work. I don't feel comfortable enough with my understanding of the expected behavior of the search functionality at this moment to actually approve
…cy.account.BaseAccount to core:account
8a73c76 to
91dde44
Compare
Uh oh!
There was an error while loading. Please reload this page.