Skip to content

Refactor: Move legacy:search to feature:search#9010

Merged
kewisch merged 1 commit into
thunderbird:mainfrom
shamim-emon:move-legacy-search-into-feature-search-module
Apr 24, 2025
Merged

Refactor: Move legacy:search to feature:search#9010
kewisch merged 1 commit into
thunderbird:mainfrom
shamim-emon:move-legacy-search-into-feature-search-module

Conversation

@shamim-emon

@shamim-emon shamim-emon commented Mar 30, 2025

Copy link
Copy Markdown
Collaborator

@shamim-emon shamim-emon force-pushed the move-legacy-search-into-feature-search-module branch 6 times, most recently from eb78553 to 9ace541 Compare April 5, 2025 06:20
@shamim-emon shamim-emon force-pushed the move-legacy-search-into-feature-search-module branch from 9ace541 to 8a73c76 Compare April 11, 2025 00:20
@shamim-emon shamim-emon requested a review from asoucar as a code owner April 11, 2025 00:20
@kewisch

kewisch commented Apr 11, 2025

Copy link
Copy Markdown
Member

@asoucar here are some of the refactorings Shamim and Wolf have been working on. We're aiming to make the modules in the feature directory fairly self-contained, to reduce dependencies and build time. What goes into the feature modules should be "the way things are intended to be". The account object is very broadly (and sometimes wrongly) used, so we need to be careful on how dependencies work here.

This is a bit over my head to really review well, if this is straightforward to you then feel free to take a look.

@asoucar asoucar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had the one actual code question but otherwise the code looks fine and like it would work. I don't feel comfortable enough with my understanding of the expected behavior of the search functionality at this moment to actually approve

Comment thread legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListConfig.kt Outdated
@shamim-emon shamim-emon force-pushed the move-legacy-search-into-feature-search-module branch from 8a73c76 to 91dde44 Compare April 12, 2025 06:51
@shamim-emon shamim-emon requested a review from asoucar April 12, 2025 06:52
@kewisch kewisch self-assigned this Apr 23, 2025
@kewisch kewisch merged commit d76fd96 into thunderbird:main Apr 24, 2025
@thunderbird-botmobile thunderbird-botmobile Bot added this to the Thunderbird 11 milestone Apr 24, 2025
@shamim-emon shamim-emon deleted the move-legacy-search-into-feature-search-module branch April 24, 2025 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move legacy:search to feature:search

4 participants