Fix(#1125) : Incorrect South Korean holiday name (Oct 3)#1201
Open
micheal000010000-hub wants to merge 1 commit intothunderbird:masterfrom
Open
Fix(#1125) : Incorrect South Korean holiday name (Oct 3)#1201micheal000010000-hub wants to merge 1 commit intothunderbird:masterfrom
micheal000010000-hub wants to merge 1 commit intothunderbird:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Corrects the name of the South Korean holiday on October 3rd.
The Calendarific API currently returns the holiday name as
건국일, which is not the official designation. The correct name is개천절(Gaecheonjeol / National Foundation Day).Changes
Calendarificmodel to replace건국일with개천절Testing
Notes
Fixes
Closes #1125