Button refactor#595
Draft
MelissaAutumn wants to merge 6 commits intomasterfrom
Draft
Conversation
…g web dev. Speeds up the site build process.
* Remove hamburger-btn overrides / style * Consolidate btn-hamburger into buttons.less * Override --nav-txt for homepage and scrolled-nav * Replace btn-no-bg with btn-transparent * Specify hero button class for homepage * Additional clean up
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing a bunch of hacks I left in, and making it so
btngives us a standard button that can be used anywhere. I need to clean it up some more so it's a draft for now but it should look exactly like how it is now.It's a little uglier (code wise) than I'd like but we can do another pass on it later.
I've also added a little performance fix for the scrolled-nav js code. I'm not entirely sure if it's doing anything different, but I kept getting random page hitches and now it's gone so 🤷
Also I've added a
--nonotesoption to avoid building release notes. This greatly speeds up builds / rebuilds.I can split up the additional changes if needed.