fix(cli,web): hide Windows spawn windows and show queued attachments#765
Merged
tiann merged 2 commits intoJun 1, 2026
Merged
Conversation
There was a problem hiding this comment.
Findings
- [Minor] Editing an attachment-only queued item now drops all visible context.
getQueuedMessagePreviewreturnstext: ''for attachment-only messages, buthandleEditstill cancels the queued message first and only restorestextinto the composer. Before this split, attachment-only rows at least reused the filename string as the edit fallback; now clicking Edit on a queued image/file leaves the composer blank after the queued message is removed. Evidence:web/src/components/AssistantChat/QueuedMessagesBar.tsx:201
Suggested fix:const { text, attachmentNames } = getQueuedMessagePreview(msg) const editText = text || attachmentNames.join(', ') // inside onSuccess if (editText) { assistantApi.composer().setText(editText) } onEdit?.({ text: editText, pendingSchedule: restoredPendingSchedule })
Summary
Review mode: initial
One minor regression found in the queued attachment UI. The Windows spawn changes look scoped; residual risk is Windows-only behavior that I could not execute in this environment.
Testing
- Not run (automation):
bunis not installed in this runner (/bin/bash: bun: command not found).
HAPI Bot
There was a problem hiding this comment.
Findings
No findings.
Summary
Review mode: follow-up after new commits
No issues found in the latest full diff. The follow-up commit addresses the previous attachment-only queued edit regression with an edit-text fallback and unit coverage. Residual risk: Windows-only process-window behavior was not executable in this Linux runner.
Testing
- Not run (automation):
bunis not installed in this runner (/bin/bash: bun: command not found). git diff --checkpassed for the changed files.
HAPI Bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Scope / impact
windowsHideon Windows.Validation
bun vitest run src/utils/spawnWithAbort.test.ts src/agent/backends/acp/AcpSdkBackend.test.ts src/utils/spawnHappyCLI.test.ts src/codex/utils/codexExecutable.test.ts src/claude/sdk/utils.test.ts src/codex/utils/codexVersion.test.ts- 6 files, 63 tests passed.bun run --cwd web test QueuedMessagesBar.test.tsx- 1 file, 17 tests passed.bun run --cwd cli tsc --noEmit- passed.bun run --cwd web typecheck- passed.git diff --check- passed.Risk / rollback
Reviewer notes
windowsHide.