fix(cli): Pi RPC parsers compatible with Zod 4 optional fields#973
Merged
Conversation
asStrOrDef/asOpt* helpers now treat missing keys as undefined so get_available_models/get_commands parsing works again. safeParse success checked explicitly. Co-authored-by: Cursor <cursoragent@cursor.com>
2 tasks
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Findings
No findings.
Summary
Review mode: initial
No issues found in the modified Pi RPC parser schema. Residual risk: local automation could not be run in this environment because bun is unavailable.
Testing
Not run (automation): bun not found in runner.
HAPI Bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parsePiModels/parsePiCommandschecksafeParsesuccess explicitlyget_available_models/get_commandsparsing sowireTransportEventscaches models and commandsTest plan
bun typecheck(repo root)cd cli && bun run test src/pi/loop.test.ts— 30/30 pass2a4ae30c, fork Test CI greenIssue
Closes #972
Disclosure
Drafted with composer via Cursor; reviewed and tested by the human contributor.