Use Brandon's new conformance tests#9
Draft
tianon wants to merge 1 commit into
Draft
Conversation
tianon
force-pushed
the
bmitch-conformance
branch
from
89f5d08 to
1636d29
Compare
Owner
Author
|
Heck yeah, a report! https://github.com/tianon/containerd-registry/actions/runs/23315940196/artifacts/6014837571 It's failing, which is exactly what I expected - this was more for the fun of putting those tests to work here. |
tianon
force-pushed
the
bmitch-conformance
branch
8 times, most recently
from
7a526bd to
07bfcdc
Compare
Owner
Author
|
Fully passing now because I made a call on cue-labs/oci#47 in my WIP branch so I could implement that one properly. Notably, this still disables sha512, but because containerd itself doesn't support it properly yet in the content store. 😅 |
tianon
force-pushed
the
bmitch-conformance
branch
4 times, most recently
from
8f47631 to
360069f
Compare
- hack `go.mod` for `ociregistry` conformance fixes
- update code for conformance fixes ("hell yeah")
- correct blob `Range:` implementation
- implement `Referrers`
- more correct errors handling (esp. translating/annotating containerd errors to ociregistry errors)
- `go fix ./...`
- use a cache mount in the `Dockerfile` for faster rebuilds slash test/dev cycles
tianon
force-pushed
the
bmitch-conformance
branch
from
360069f to
c576cbd
Compare
Owner
Author
|
Welp, with containerd/containerd#13147, this passes all but 9 tests when I re-enable sha512, and all 9 are |
Owner
Author
|
What I didn't realize/expect is that all 9 failures likely root case in cue-labs/oci#45 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go.modforociregistryconformance fixesRange:implementationReferrers