fix: additions for prisma 6.17 and engineType = "client" compat#39
Merged
shiyuhang0 merged 2 commits intoOct 28, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
Updates the TiDB Cloud Prisma adapter for compatibility with Prisma 6.17 and engineType = "client" by adding argument mapping functionality and date formatting utilities.
- Upgrades
@prisma/driver-adapter-utilsdependency from 6.12.0 to 6.17.0 - Adds argument mapping with type-specific conversions for BigInt, Date, and Bytes types
- Implements date/time formatting functions for database compatibility
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| package.json | Updates dependency version to support Prisma 6.17 |
| src/conversion.ts | Adds mapArg function and date formatting utilities for type conversion |
| src/tidbcloud.ts | Integrates argument mapping in query execution to handle typed parameters |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
shiyuhang0
approved these changes
Oct 16, 2025
shiyuhang0
approved these changes
Oct 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Porting some additions from the prisma mariadb adapter (I assume it should roughly map to tidb since it's MySQL). I haven't tested them carefully, but this makes it pass the prisma ecosystem tests for latest Prisma and
engineType = "client".