Skip to content

fix: additions for prisma 6.17 and engineType = "client" compat#39

Merged
shiyuhang0 merged 2 commits into
tidbcloud:mainfrom
jacek-prisma:feat/prisma-6-17-support
Oct 28, 2025
Merged

fix: additions for prisma 6.17 and engineType = "client" compat#39
shiyuhang0 merged 2 commits into
tidbcloud:mainfrom
jacek-prisma:feat/prisma-6-17-support

Conversation

@jacek-prisma
Copy link
Copy Markdown
Contributor

@jacek-prisma jacek-prisma commented Oct 8, 2025

Porting some additions from the prisma mariadb adapter (I assume it should roughly map to tidb since it's MySQL). I haven't tested them carefully, but this makes it pass the prisma ecosystem tests for latest Prisma and engineType = "client".

@pingcap-cla-assistant
Copy link
Copy Markdown

pingcap-cla-assistant Bot commented Oct 8, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates the TiDB Cloud Prisma adapter for compatibility with Prisma 6.17 and engineType = "client" by adding argument mapping functionality and date formatting utilities.

  • Upgrades @prisma/driver-adapter-utils dependency from 6.12.0 to 6.17.0
  • Adds argument mapping with type-specific conversions for BigInt, Date, and Bytes types
  • Implements date/time formatting functions for database compatibility

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.

File Description
package.json Updates dependency version to support Prisma 6.17
src/conversion.ts Adds mapArg function and date formatting utilities for type conversion
src/tidbcloud.ts Integrates argument mapping in query execution to handle typed parameters
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread src/conversion.ts
Comment thread src/conversion.ts
@ti-chi-bot ti-chi-bot Bot added the size/L label Oct 28, 2025
@shiyuhang0 shiyuhang0 merged commit d785ecd into tidbcloud:main Oct 28, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants