Skip to content

Commit cad57ab

Browse files
committed
fix all
1 parent d56f8c6 commit cad57ab

5 files changed

Lines changed: 11 additions & 14 deletions

File tree

internal/cli/serverless/privatelink/create.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,10 +70,10 @@ func CreateCmd(h *internal.Helper) *cobra.Command {
7070
$ %[1]s serverless private-link-connection create
7171
7272
Create a private link connection which connect to alicloud endpoint service (non-interactive):
73-
$ %[1]s serverless private-link-connection create -c <cluster-id> --display-name <name> --type ALICLOUD_ENDPOINT_SERVICE --alicloud.endpoint-service.name <name>
73+
$ %[1]s serverless private-link-connection create -c <cluster-id> --display-name <name> --type ALICLOUD_ENDPOINT_SERVICE --alicloud.endpoint-service-name <name>
7474
7575
Create a private link connection which connect to aws endpoint service (non-interactive):
76-
$ %[1]s serverless private-link-connection create -c <cluster-id> --display-name <name> --type AWS_ENDPOINT_SERVICE --aws.endpoint-service.name <name>`, config.CliName),
76+
$ %[1]s serverless private-link-connection create -c <cluster-id> --display-name <name> --type AWS_ENDPOINT_SERVICE --aws.endpoint-service-name <name>`, config.CliName),
7777
PreRunE: func(cmd *cobra.Command, args []string) error {
7878
return opts.MarkInteractive(cmd)
7979
},

internal/cli/serverless/privatelink/delete.go

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ import (
2525
"github.com/tidbcloud/tidbcloud-cli/internal"
2626
"github.com/tidbcloud/tidbcloud-cli/internal/config"
2727
"github.com/tidbcloud/tidbcloud-cli/internal/flag"
28-
"github.com/tidbcloud/tidbcloud-cli/internal/output"
2928
"github.com/tidbcloud/tidbcloud-cli/internal/service/cloud"
3029
)
3130

@@ -135,18 +134,17 @@ func DeleteCmd(h *internal.Helper) *cobra.Command {
135134
}
136135
}
137136

138-
res, err := d.DeletePrivateLinkConnection(ctx, clusterID, plcID)
137+
_, err = d.DeletePrivateLinkConnection(ctx, clusterID, plcID)
139138
if err != nil {
140139
return errors.Trace(err)
141140
}
142141
fmt.Fprintln(h.IOStreams.Out, color.GreenString("Private link connection deleted"))
143-
_ = output.PrintJson(h.IOStreams.Out, res)
144142
return nil
145143
},
146144
}
147145

148146
cmd.Flags().StringP(flag.ClusterID, flag.ClusterIDShort, "", "The cluster ID.")
149-
cmd.Flags().StringP(flag.PrivateLinkConnectionID, flag.PrivateLinkConnectionIDShort, "", "The private link connection ID.")
147+
cmd.Flags().String(flag.PrivateLinkConnectionID, "", "The private link connection ID.")
150148
cmd.Flags().BoolVar(&force, flag.Force, false, "Delete without confirmation.")
151149
return cmd
152150
}

internal/cli/serverless/privatelink/describe.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,6 +127,6 @@ func DescribeCmd(h *internal.Helper) *cobra.Command {
127127
}
128128

129129
cmd.Flags().StringP(flag.ClusterID, flag.ClusterIDShort, "", "The cluster ID.")
130-
cmd.Flags().StringP(flag.PrivateLinkConnectionID, flag.PrivateLinkConnectionIDShort, "", "The private link connection ID.")
130+
cmd.Flags().String(flag.PrivateLinkConnectionID, "", "The private link connection ID.")
131131
return cmd
132132
}

internal/cli/serverless/privatelink/privatelink.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ func PrivateLinkConnectionCmd(h *internal.Helper) *cobra.Command {
2424
cmd := &cobra.Command{
2525
Use: "private-link-connection",
2626
Aliases: []string{"plc", "private-link"},
27-
Short: "Manage private link connections",
27+
Short: "Manage private link connections for dataflow",
2828
}
2929

3030
cmd.AddCommand(

internal/flag/flag.go

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -119,12 +119,11 @@ const (
119119
Explain string = "explain"
120120
ChangefeedTemplateType string = "type"
121121

122-
PrivateLinkConnectionID string = "private-link-connection-id"
123-
PrivateLinkConnectionIDShort string = "p"
124-
PrivateLinkConnectionType string = "type"
125-
AWSEndpointServiceName string = "aws.endpoint-service.name"
126-
AWSEndpointServiceRegion string = "aws.endpoint-service.region"
127-
AlicloudEndpointServiceName string = "alicloud.endpoint-service.name"
122+
PrivateLinkConnectionID string = "private-link-connection-id"
123+
PrivateLinkConnectionType string = "type"
124+
AWSEndpointServiceName string = "aws.endpoint-service-name"
125+
AWSEndpointServiceRegion string = "aws.endpoint-service-region"
126+
AlicloudEndpointServiceName string = "alicloud.endpoint-servicename"
128127
)
129128

130129
const OutputHelp = "Output format, one of [\"human\" \"json\"]. For the complete result, please use json format."

0 commit comments

Comments
 (0)