add private link connection command#304
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
license-eye has checked 773 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 203 | 1 | 569 | 0 |
Click to see the invalid file list
- internal/cli/serverless/privatelink/ui.go
Use this command to fix any missing license headers
```bash
docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix
</details>
zhangyangyu
reviewed
Nov 27, 2025
zhangyangyu
reviewed
Nov 27, 2025
zhangyangyu
reviewed
Nov 27, 2025
zhangyangyu
reviewed
Nov 27, 2025
zhangyangyu
reviewed
Nov 27, 2025
There was a problem hiding this comment.
Pull request overview
This PR adds support for managing private link connections in TiDB Cloud Serverless clusters. It introduces a new set of CLI commands and integrates with the TiDB Cloud API to create, list, describe, and delete private link connections for both AWS and Alicloud endpoint services.
- Generated OpenAPI client code for the private link connection API
- Added CLI commands (create, delete, describe, list, zones) under
serverless private-link-connection - Integrated private link connection API client with the existing cloud service infrastructure
- Added interactive and non-interactive modes for all commands with proper validation
Reviewed changes
Copilot reviewed 44 out of 44 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
pkg/tidbcloud/v1beta1/serverless/privatelink/* |
Auto-generated OpenAPI client code for private link connection API |
internal/service/cloud/api_client.go |
Added API client delegate methods for private link connection operations |
internal/service/cloud/logic.go |
Added business logic for selecting and retrieving private link connections |
internal/cli/serverless/privatelink/*.go |
CLI command implementations for create, delete, describe, list, and zones operations |
internal/flag/flag.go |
Added new flag constants for private link connection parameters |
internal/cli/serverless/cluster.go |
Integrated private link connection command into serverless CLI |
internal/mock/api_client.go |
Updated mock client with private link connection methods |
docs/generate_doc/*.md |
Auto-generated documentation for new CLI commands |
Makefile |
Added generation target for private link client |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
zhangyangyu
approved these changes
Nov 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.