Fix forbidden/unauthorized http status mixup

Author: simonbaird

rails/app/controllers/tiddlywiki_controller.rb

@@ -201,12 +201,10 @@ def site_not_available_status
     return [404, 'Not Found'] if action_name == 'download' && site_visible? && site_download_url_disabled?
 
     # User signed in, site unavailable
-    # Fixme: Actually the name is wrong, should be [403, 'Forbidden']
-    return [403, 'Unauthorized'] if user_signed_in?
+    return [403, 'Forbidden'] if user_signed_in?
 
     # User not signed in, site unavailable
-    # Fixme: Actually the name is wrong, should be [401, 'Unauthorized']
-    [401, 'Forbidden']
+    [401, 'Unauthorized']
   end
 
   def site_visible?

rails/test/integration/sites_test.rb

@@ -192,11 +192,11 @@ def assert_is_404
   end
 
   def assert_is_401
-    assert_is_status(401, 'Forbidden')
+    assert_is_status(401, 'Unauthorized')
   end
 
   def assert_is_403
-    assert_is_status(403, 'Unauthorized')
+    assert_is_status(403, 'Forbidden')
   end
 
   def assert_is_status(status_code, status_message)