[BACK-2540] Reports api#77
Open
jh-bate wants to merge 21 commits into
Open
Conversation
formatting updates for consistency
allow daterange per report
toddkazakov
requested changes
Jul 28, 2023
| type: string | ||
| description: The medical record number of the patient | ||
| minLength: 1 | ||
| $ref: ../../metadata/models/mrn.v1.yaml |
Contributor
There was a problem hiding this comment.
Making changes to clinic service models is undesirable, because the clinic and server stubs are generated from this spec. I have previously found the deep references are not well supported by the code generator and cause issues.
Contributor
Author
There was a problem hiding this comment.
all done @toddkazakov - I have removed that update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Single user report API request (assuming we include multiple users reports later) This is from the working example that @krystophv and I have worked on in the export service to be accessed by blip also
Implementation tidepool-org/export#43
also included: